[jira] Commented: (JCR-2651) Add a OnWorkspaceInconsistency with logging only

["Sergiy Shyrkov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890276#action_12890276 ] 

Sergiy Shyrkov commented on JCR-2651:
-------------------------------------

Hello Claus,

there is a small issue with the committed patch (I used in on my Jackrabbit 1.x deployment).
The output is as follows:

2010-07-20 16:39:08,367: ERROR [OnWorkspaceInconsistency] - Node [Ljava.lang.Object;@18f238fc. Please run a consistency check on this workspace! ({}) has missing child '{}' ({})

In the code you are concatenating the arguments object array with a string:

   log.error("Node {} ({}) has missing child '{}' ({})", new Object[]{...} + ". Please run a consistency check on this workspace!");

so it results in replacing only the first argument.

I guess, you intention was to do:

   log.error("Node {} ({}) has missing child '{}' ({}). Please run a consistency check on this workspace!", new Object[]{...});

instead.

Kind regards
Sergiy

> Add a OnWorkspaceInconsistency with logging only
> ------------------------------------------------
>
>                 Key: JCR-2651
>                 URL: https://issues.apache.org/jira/browse/JCR-2651
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-core
>    Affects Versions: 1.6.2, 2.1.0
>            Reporter: Claus Köll
>            Assignee: Claus Köll
>             Fix For: 1.6.3, 2.1.1
>
>         Attachments: JCR-2651.patch
>
>
> If a Workspace performs a re-index on startup with  a inconsistency in it the process will fail now.
> The new OnWorkspaceInconsistency "log" will only log the inconsistency but the reindex-process will not fail

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.