You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hong Tang (JIRA)" <ji...@apache.org> on 2009/07/31 09:34:15 UTC
[jira] Created: (HADOOP-6172) bin/hadoop version not working
bin/hadoop version not working
------------------------------
Key: HADOOP-6172
URL: https://issues.apache.org/jira/browse/HADOOP-6172
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 0.21.0
Reporter: Hong Tang
Priority: Minor
Two problems found:
- ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
- bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737701#action_12737701 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6172:
------------------------------------------------
> Also, I think whatever tests might be automated with a relatively low effort should be automated. ...
Since our build process does not support script unit tests, I think it is not a relatively low effort to add a test for this issue. The fixes in this issue are simple but important. Even we decide to create unit tests for script, how about do it in a separated issue, so that we can commit this first?
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737448#action_12737448 ]
Hong Tang commented on HADOOP-6172:
-----------------------------------
Problem symptoms:
% bin/hadoop version
Hadoop Unknown
Subversion Unknown -r Unknown
Compiled by Unknown on Unknown
>From source with checksum Unknown
% build/hadoop-core-0.21.0-dev/bin/hadoop version
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/hadoop/util/VersionInfo
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.util.VersionInfo
at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
at java.lang.ClassLoader.loadClass(ClassLoader.java:319)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:330)
at java.lang.ClassLoader.loadClass(ClassLoader.java:254)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:402)
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Priority: Minor
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737641#action_12737641 ]
Konstantin Boudnik commented on HADOOP-6172:
--------------------------------------------
Shouldn't we have a primitive unit test to check bin/hadoop version result? I believe this is a very basic sanity test too.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737631#action_12737631 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6172:
------------------------------------------------
+1 patch looks good.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737864#action_12737864 ]
Hudson commented on HADOOP-6172:
--------------------------------
Integrated in Hadoop-Common-trunk #41 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/41/])
. Fix jar file names in hadoop-config.sh and include ${build.src} as a part of the source list in build.xml. Contributed by Hong Tang
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737452#action_12737452 ]
Hong Tang commented on HADOOP-6172:
-----------------------------------
@sreekanth, I am not sure if they are the same problem. For HADOOP-4503, call "ant jar" twice would resolve the problem. But for this one, a java file (build/src/org/apache/hadoop/package-info.java) is simply not compiled and deposited to build/classes directory.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737633#action_12737633 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6172:
------------------------------------------------
Since this is a script changes, test-patch and unit tests are not related. I am going to commit this without submitting it to hudson.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6172) bin/hadoop version not working
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated HADOOP-6172:
------------------------------
Attachment: hadoop-6172-20090731.patch
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737648#action_12737648 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6172:
------------------------------------------------
> Shouldn't we have a primitive unit test to check bin/hadoop version result? ..
I think this is a good idea but we do not have any unit test to test any script (correct me if I am wrong). Not sure why we are not creating unit tests for scripts. I guess we usually do manual tests for scripts. Are you proposing to add unit tests for scripts?
Holding on the commit.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737449#action_12737449 ]
Sreekanth Ramakrishnan commented on HADOOP-6172:
------------------------------------------------
HADOOP-4503 actually talks about the first problem which is mentioned in this JIRA.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Priority: Minor
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6172) bin/hadoop version not working
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6172:
-------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Tested manually as shown below:
{noformat}
bash-3.2$ ./bin/hadoop version
Hadoop Unknown
Subversion Unknown -r Unknown
Compiled by Unknown on Unknown
>From source with checksum Unknown
# apply patch and recompile
bash-3.2$ patch -p0 -i ../hadoop-6172-20090731.patch
...
bash-3.2$ ./bin/hadoop version
Hadoop 0.21.0-dev
Subversion https://svn.apache.org/repos/asf/hadoop/common/trunk -r 798247
Compiled by tsz on Fri Jul 31 14:40:51 PDT 2009
>From source with checksum 4cec386d7ec492be92e14fc12a5a50a4
{noformat}
I have committed this. Thanks, Hong!
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737675#action_12737675 ]
Konstantin Boudnik commented on HADOOP-6172:
--------------------------------------------
I'm not sure why the dependency would be changed - it seems that scripts are coming directly from SVN and nothing special is required to run
{noformat}
bin/hadoop version
{noformat}
but compilation. Thus certain script tests won't require anything special too. Am I mistaken?
Also, I think whatever tests might be automated with a relatively low effort should be automated. Manual tests aren't that efficient nor error proof. E.g. in the current common trunk bin/hadoop version produces a lot of 'unknown' version tags which might've been caught by a routinely executed test.
Shall we start adding tests for scripts right now? Why not - this day isn't worst than any consequent one :-)
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737692#action_12737692 ]
Hong Tang commented on HADOOP-6172:
-----------------------------------
@Cos, in this particular case, I want to conduct two tests:
- $hadoop-src-dir/bin/hadoop version
- $hadoop-src-dir/build/hadoop-xxx/bin/hadoop version
The second test requires hadoop being copied to build/bin, which would not happen until "ant tar" is called. So the second test would depend on "tar" target.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737660#action_12737660 ]
Hong Tang commented on HADOOP-6172:
-----------------------------------
Such test could change the dependency, because it is testing whether the tar target runs correctly. Or we probably could incorporate it as part of the "test-patch" target (because that would build a tar in the process).
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6172) bin/hadoop version not working
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737711#action_12737711 ]
Konstantin Boudnik commented on HADOOP-6172:
--------------------------------------------
Fine with me. Let's commit this first. To track the scripts testing I've created HADOOP-6172
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6172) bin/hadoop version not working
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated HADOOP-6172:
------------------------------
Fix Version/s: 0.21.0
Assignee: Hong Tang
Status: Patch Available (was: Open)
Trivial patch that fixes both problems. No junit test required. Manually tested and confirmed to resolve the problems.
> bin/hadoop version not working
> ------------------------------
>
> Key: HADOOP-6172
> URL: https://issues.apache.org/jira/browse/HADOOP-6172
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6172-20090731.patch
>
>
> Two problems found:
> - ${build.src} not included in ant target "compile-core-classes", thus o.a.h.package-info.java is not compiled, which contains the version annotation.
> - bin/hadoop-config.sh attempts to include jar files matching pattern hadoop-*-core.jar rather than hadoop-core-*.jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.