You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/08/24 20:33:27 UTC

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r212746377
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -130,6 +130,16 @@ private[spark] class Executor(
       private val urlClassLoader = createClassLoader()
       private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
     
    +  // One thread will handle loading all of the plugins on this executor
    +  val executorPluginThread = new Thread {
    +    override def run: Unit = {
    +      conf.get(EXECUTOR_PLUGINS).foreach { classes =>
    +        Utils.loadExtensions(classOf[ExecutorPlugin], classes, conf)
    +      }
    +    }
    +  }
    +  executorPluginThread.start
    --- End diff --
    
    start()


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org