You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/08 22:16:57 UTC
[GitHub] [druid] vogievetsky opened a new pull request #10496: Web console: show segment sizes in rows not bytes
vogievetsky opened a new pull request #10496:
URL: https://github.com/apache/druid/pull/10496
This PR addresses the feedback from the recent work on the new segment distribution in the console. Segment sizes should be in rows not megabytes to fit with the new Druid documentation https://github.com/apache/druid/blob/master/docs/operations/segment-optimization.md
Old:
New:
This PR also cleans up some types and adds a nice little error action hint for 3 of the most common SQL query errors (see bottom of screenshot):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502163499
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
Review comment:
what if `==` is part of a literal? Does `str#replace` replace all instances of the regex in the string? Similar comments for other uses of `replace` function in this code block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #10496:
URL: https://github.com/apache/druid/pull/10496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502163499
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
Review comment:
what if `==` is part of a literal? Does `str#replace` replace all instances of the regex in the string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r503576325
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -144,42 +144,41 @@ function progress(done: number, awaiting: number): number {
const PERCENT_BRACES = [formatPercent(1)];
-interface Datasource {
- datasource: string;
- rules: Rule[];
- compactionConfig?: CompactionConfig;
- compactionStatus?: CompactionStatus;
- [key: string]: any;
+interface DatasourceQueryResultRow {
+ readonly datasource: string;
+ readonly num_segments: number;
+ readonly num_available_segments: number;
+ readonly num_segments_to_load: number;
+ readonly num_segments_to_drop: number;
+ readonly total_data_size: number;
+ readonly replicated_size: number;
+ readonly min_segment_size: number;
+ readonly avg_segment_size: number;
+ readonly max_segment_size: number;
Review comment:
nit: should this be `min_segment_rows` ... instead of size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502554718
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
Review comment:
yeah it is pretty blunt, just replaces all the `==` with `=`... Maybe it should be aware of the line markers in the error text
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502572389
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average / maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
I don't have a strong opinion on this, and will defer to your judgement.
The risk with rounding to millions is that for smaller datasources, it could always show `0.000 M`
I wonder if the UI could use the largest rounding per datasource. So you could have something like
```
DS1 5.343 M, 0.004 M, 0.000 M
DS2 0.320 k, 0.120 k, 321.1 k
```
^ even in this example, I'm really confused about how to pick whether to keep it as `321.1 k` or `0.321 M`
Number formatting isn't my forte 🙃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502166010
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average / maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
Is this wide enough to handle 7 digits for min, avg and max?
From the doc linked in this PR `it's generally recommended for each segment to have around 5 million rows`
Do you think it's users would want to see a rounded number instead - something like `2.1M` instead of `2,105,248`
^ just a thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r503005216
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average / maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502162405
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
+ },
+ };
+ }
+
+ // Incorrect quoting on table
+ const mq = errorMessage.match(/Column '([^']+)' not found in any table/);
+ if (mq) {
+ const literalString = mq[1];
+ return {
+ label: `Replace "${literalString}" with '${literalString}'`,
+ fn: str => {
+ if (!str.includes(`"${literalString}"`)) return;
+ return str.replace(`"${literalString}"`, `'${literalString}'`);
+ },
+ };
+ }
+
+ // , before FROM
+ const mc = errorMessage.match(/Encountered "(FROM)" at/i);
Review comment:
what does `mq` and `mc` stand for?
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
Review comment:
what if `==` is part of a literal? Does `str#replace` replace all instances of the regex in the string?
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
Review comment:
what if `==` is part of a literal? Does `str#replace` replace all instances of the regex in the string? Similar comments for other uses of `replace` function in this code block
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average / maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
Is this wide enough to handle 7 digits for min, avg and max?
From the doc linked in this PR `it's generally recommended for each segment to have around 5 million rows`
Do you think it's users would want to see a rounded number instead - something like `2.1M` instead of `2,105,248`
^ just a thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #10496:
URL: https://github.com/apache/druid/pull/10496#issuecomment-706946849
> is the segment size in bytes not going to be shown anywhere in the UI?
>
> I was thinking to only show one... maybe we could add all the details in the ... detail view
>
> Another tab in this dialog
Thanks. The `segments` tab has all the details so that suffices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502162405
##########
File path: web-console/src/utils/druid-query.ts
##########
@@ -92,12 +97,55 @@ export class DruidError extends Error {
return;
}
+ static getSuggestion(errorMessage: string): QuerySuggestion | undefined {
+ // == is used instead of =
+ if (errorMessage.includes('Encountered "= =" at')) {
+ return {
+ label: `Replace == with =`,
+ fn: str => {
+ if (!str.includes('==')) return;
+ return str.replace(/==/g, '=');
+ },
+ };
+ }
+
+ // Incorrect quoting on table
+ const mq = errorMessage.match(/Column '([^']+)' not found in any table/);
+ if (mq) {
+ const literalString = mq[1];
+ return {
+ label: `Replace "${literalString}" with '${literalString}'`,
+ fn: str => {
+ if (!str.includes(`"${literalString}"`)) return;
+ return str.replace(`"${literalString}"`, `'${literalString}'`);
+ },
+ };
+ }
+
+ // , before FROM
+ const mc = errorMessage.match(/Encountered "(FROM)" at/i);
Review comment:
what does `mq` and `mc` stand for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10496:
URL: https://github.com/apache/druid/pull/10496#issuecomment-706793633
> is the segment size in bytes not going to be shown anywhere in the UI?
I was thinking to only show one... maybe we could add all the details in the ... detail view
Another tab in this dialog
![Uploading image.png…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10496:
URL: https://github.com/apache/druid/pull/10496#issuecomment-707428235
> I thought that size could be measured in rows... will rename
Marked the change as Approved. I see `avg_row_size` is in MB which is what made me think about the difference between that and `min_segment_size`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502986373
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average / maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
What do you think about
The only numbers that would be rendered as `0.000 M` would be numbers `<= 500` so we could display them directly.
Side note: There is a style pass happening on a different branch that would change the font to one that has monospaced numbers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #10496:
URL: https://github.com/apache/druid/pull/10496#issuecomment-705951556
is the segment size in bytes not going to be shown anywhere in the UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #10496:
URL: https://github.com/apache/druid/pull/10496#issuecomment-705951556
is the segment size in bytes not going to be shown anywhere in the UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502556409
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average / maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
I wanted them all to be consistently formatted with the same abbreviation. So not to have `7.6 M`, `4.3 k`, and `233` all in the same column. What if we format it as millions with 3 digits:
`5.343 M`, `0.004 M`, `0.000 M`
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10496:
URL: https://github.com/apache/druid/pull/10496#issuecomment-707415955
I thought that size could be measured in rows... will rename
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #10496: Web console: show segment sizes in rows not bytes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r504083618
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -144,42 +144,41 @@ function progress(done: number, awaiting: number): number {
const PERCENT_BRACES = [formatPercent(1)];
-interface Datasource {
- datasource: string;
- rules: Rule[];
- compactionConfig?: CompactionConfig;
- compactionStatus?: CompactionStatus;
- [key: string]: any;
+interface DatasourceQueryResultRow {
+ readonly datasource: string;
+ readonly num_segments: number;
+ readonly num_available_segments: number;
+ readonly num_segments_to_load: number;
+ readonly num_segments_to_drop: number;
+ readonly total_data_size: number;
+ readonly replicated_size: number;
+ readonly min_segment_size: number;
+ readonly avg_segment_size: number;
+ readonly max_segment_size: number;
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org