You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nchammas <gi...@git.apache.org> on 2015/02/06 03:43:04 UTC
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/4414
[SPARK-5628] Add version option to spark-ec2
Every proper command line tool should include a `--version` option or something similar.
This PR adds this to `spark-ec2` using the standard functionality provided by `optparse`.
One thing we don't do here is follow the Python convention of setting `__version__`, since it seems awkward given how `spark-ec2` is laid out.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark spark-ec2-show-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4414
----
commit d4c5f438f4bb46d223f36f28c7394210c9d2fa2b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-06T03:21:16Z
Merge pull request #6 from apache/master
merge upstream changes
commit 03180a4e9dc8f949b8d3372c54738547ca3813c1
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-10T23:39:14Z
Merge branch 'master' of github.com:nchammas/spark
commit 8051486bbfd13dbab17b30c89ef5b4ce49d3460b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:22:18Z
Merge pull request #1 from apache/master
merge upstream changes
commit 0b47ca4b8c3497913c3eb5db3c30e63248491938
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:27:19Z
Merge branch 'master' of github.com:nchammas/spark
commit e33b9787d24c52dd33b71a83c42b0a8f7033ff5e
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-17T20:48:48Z
Merge pull request #2 from apache/master
merge upstream changes
commit ce1a3ebe63fc49e6ce17968f5b220122e3c1ff97
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-19T18:27:16Z
Merge pull request #3 from apache/master
merge upstream changes
commit 222ae4e313ad594673109ab2ee2eb56425afda34
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-23T17:16:48Z
Merge pull request #4 from apache/master
merge upstream changes
commit df33cbb0bc317774a78022840c1a346a904617f3
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-23T19:17:23Z
Merge pull request #5 from apache/master
merge upstream changes
commit 7b2e9712442ef1aaa0bce701e2a486f6a04e113c
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-26T20:53:55Z
Merge pull request #6 from apache/master
merge upstream changes
commit f47188329b388e878626cbfd05412500b63284e1
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-29T15:28:12Z
Merge pull request #7 from apache/master
merge upstream changes
commit c5d073d427b529ad53cb0c26961fe7cadfd873a2
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-30T17:41:03Z
Merge pull request #8 from apache/master
merge upstream changes
commit 088645af68f2ddde22f88a8dfb9aa10673d35b6a
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-30T22:30:04Z
Merge pull request #9 from apache/master
merge upstream changes
commit 6b273648505c4dd31d7417952068053b6015fcc5
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-10-06T21:00:36Z
Merge pull request #10 from apache/master
merge upstream changes
commit 410e75670d92f091e6a14f8fbae158d5ac0039bc
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-10-08T01:06:32Z
Merge pull request #11 from apache/master
merge upstream changes
commit 0a0f2a0d39f008861dd60d25e60eb591dfd2c5e1
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-10-29T02:35:23Z
Merge pull request #12 from apache/master
merge upstream changes
commit 25fd10b3ea6f0ae1d52412f644f120d542717816
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-11-03T17:14:08Z
Merge pull request #13 from apache/master
merge upstream changes
commit f475dd50dd8a75703b0d921a8a5a5fba91eb68a9
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-11-10T22:49:34Z
Merge pull request #14 from apache/master
merge upstream changes
commit 4e2c34379a60ae64b711bb31efa71133a5bd3bba
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-12-02T17:55:51Z
Merge pull request #15 from apache/master
merge upstream changes
commit b9bde9800cf4412e15a1dfa91c6d9ef0a6686481
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-12-08T19:39:17Z
Merge pull request #16 from apache/master
merge upstream changes
commit 6b70ba4cd620e85784f12f24cfef54df153a9637
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-12-21T07:35:35Z
Merge pull request #18 from apache/master
merge upstream changes
commit e1bf63a0d2d9e0ce259bfbc3dca2f919fdbac746
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-12-24T03:40:05Z
Merge pull request #19 from apache/master
merge upstream changes
commit aa7222c10d0a1861bb53285d1aa1daafb09984a0
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-12-26T01:10:18Z
Merge pull request #20 from apache/master
merge upstream changes
commit d208eaeed8f6dfcbccc09a9db150f71c65d7703d
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-01-07T04:09:53Z
Merge pull request #21 from apache/master
merge upstream changes
commit 5985bb1de2ca8600e4baca3149faeec702eca5c4
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-01-07T21:32:40Z
Merge pull request #22 from apache/master
merge upstream
commit 32411971a0f5cfb17083acef2026585cda4dcf62
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-01-10T04:42:29Z
Merge pull request #23 from apache/master
merge upstream
commit 69a7dac4223bfe6f052c9f61052177f1c67bbdfa
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-01-23T22:44:19Z
Merge pull request #24 from apache/master
merge upstream
commit f293cf6ef7fcbd2fa5d309d5a95119f8b57f4840
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-01-28T20:53:01Z
Merge pull request #25 from apache/master
merge upstream
commit b146bf9f28b597e6b0ab3f81850361eb0fd3562d
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-02-03T21:27:19Z
Merge pull request #26 from apache/master
merge upstream
commit e857108e8bf44c8fe4b32415669cde0f1d554e5a
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-02-06T01:50:25Z
Merge pull request #27 from apache/master
merge upstream
commit 31ec6f1e64a1f01a33327d78ae7b2341901112ce
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2015-02-06T02:38:07Z
add version info
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4414
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73304352
Actually, I'm going to hold off on the `branch-1.2` (1.2.2) commit for now, since there's a bit of divergence in that branch and I don't want to break anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73314682
I'm assuming that the 1.2.1 vote will pass, so anything new that goes into branch-1.2 will be part of 1.2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73179437
[Test build #26887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26887/consoleFull) for PR 4414 at commit [`914cab5`](https://github.com/apache/spark/commit/914cab57940cd11c4885ee29cb3f92f9ea2ee27f).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73315493
Yeah, you shouldn't need to keep the branch around. GitHub should keep the code around in this PR even if you delete the branch at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73307181
Thanks for the review @JoshRosen. I'll tag the JIRA issue for backport.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73307326
Btw, did you mean 1.2.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73188010
cc @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73179443
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26887/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-76534880
I'm going to backport this to 1.2 and change the version specified here to 1.2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73314803
(I actually use a set of [TextExpander](http://smilesoftware.com/TextExpander/index.html) macros for writing my commit messages, so I only need to type `;b12` to insert `branch-1.2` (1.2.2).)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73174472
[Test build #26887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26887/consoleFull) for PR 4414 at commit [`914cab5`](https://github.com/apache/spark/commit/914cab57940cd11c4885ee29cb3f92f9ea2ee27f).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73315220
Oh, nice.
BTW, I don't need to keep this branch around for you to backport into 1.2 right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5628] Add version option to spark-ec2
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4414#issuecomment-73303739
LGTM. I'm going to pull this into `master` (1.4.0) and `branch-1.3` (1.3.0). I'll also commit it to `branch-1.2` (1.2.2), but for that I'll update the version number to match the existing number used in those branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org