You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/23 17:08:46 UTC
[kudu-CR] [Java] Remove hard coded usage of /target directory
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10154
Change subject: [Java] Remove hard coded usage of /target directory
......................................................................
[Java] Remove hard coded usage of /target directory
This causes tests to fail in Gradle.
Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
A java/kudu-spark-tools/src/test/resources/TestImportExportFiles.csv
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
5 files changed, 59 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10154/1
--
To view, visit http://gerrit.cloudera.org:8080/10154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
Gerrit-Change-Number: 10154
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Remove hard coded usage of /target directory
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10154 )
Change subject: [Java] Remove hard coded usage of /target directory
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
Gerrit-Change-Number: 10154
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Apr 2018 18:04:20 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Remove hard coded usage of /target directory
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10154
to look at the new patch set (#2).
Change subject: [Java] Remove hard coded usage of /target directory
......................................................................
[Java] Remove hard coded usage of /target directory
This causes tests to fail in Gradle.
Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
A java/kudu-spark-tools/src/test/resources/TestImportExportFiles.csv
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
5 files changed, 59 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10154/2
--
To view, visit http://gerrit.cloudera.org:8080/10154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
Gerrit-Change-Number: 10154
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [Java] Remove hard coded usage of /target directory
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10154 )
Change subject: [Java] Remove hard coded usage of /target directory
......................................................................
[Java] Remove hard coded usage of /target directory
This causes tests to fail in Gradle.
Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
Reviewed-on: http://gerrit.cloudera.org:8080/10154
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
A java/kudu-spark-tools/src/test/resources/TestImportExportFiles.csv
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
5 files changed, 59 insertions(+), 51 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6a27e2b049a5a25cee070edd8c7d57d55f177e8
Gerrit-Change-Number: 10154
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>