You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/30 15:49:17 UTC
[GitHub] [incubator-doris] dataalive opened a new pull request, #9341: [doc]fix geo funtion st_distance_sphere
dataalive opened a new pull request, #9341:
URL: https://github.com/apache/incubator-doris/pull/9341
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
add ST_Distance_Sphere function parameter values range restrictions
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (Yes)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9341: [doc]fix geo funtion st_distance_sphere
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9341:
URL: https://github.com/apache/incubator-doris/pull/9341#issuecomment-1118097545
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9341: [doc]fix geo funtion st_distance_sphere
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9341:
URL: https://github.com/apache/incubator-doris/pull/9341#issuecomment-1114010032
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9341: [doc]fix geo funtion st_distance_sphere
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #9341:
URL: https://github.com/apache/incubator-doris/pull/9341#discussion_r862397861
##########
docs/zh-CN/sql-manual/sql-functions/spatial-functions/st_distance_sphere.md:
##########
@@ -28,11 +28,14 @@ under the License.
### description
#### Syntax
-`DOUBLE ST_Distance_Sphere(DOUBLE x_lng, DOUBLE x_lat, DOUBLE y_lng, DOUBLE x_lat)`
+`DOUBLE ST_Distance_Sphere(DOUBLE x_lng, DOUBLE x_lat, DOUBLE y_lng, DOUBLE y_lat)`
计算地球两点之间的球面距离，单位为 米。传入的参数分别为X点的经度，X点的纬度，Y点的经度，Y点的纬度。
+x_lng 和 y_lng 都是经度数据，合理的取值范围是 [-180, 180]。
+x_lat 和 y_lat 都是维度数据，合理的取值范围是 [-90, 90]。
Review Comment:
```suggestion
x_lat 和 y_lat 都是纬度数据，合理的取值范围是 [-90, 90]。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9341: [doc]fix geo funtion st_distance_sphere
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9341:
URL: https://github.com/apache/incubator-doris/pull/9341#issuecomment-1114010035
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9341: [doc]fix geo funtion st_distance_sphere
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9341:
URL: https://github.com/apache/incubator-doris/pull/9341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9341: [doc]fix geo funtion st_distance_sphere
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9341:
URL: https://github.com/apache/incubator-doris/pull/9341#issuecomment-1117332765
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org