You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/19 16:04:34 UTC
[GitHub] [arrow-datafusion] ovr opened a new pull request #1615: feat: Support complex interval via IntervalMonthDayNano
ovr opened a new pull request #1615:
URL: https://github.com/apache/arrow-datafusion/pull/1615
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/1017.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1615: feat: Support complex interval via IntervalMonthDayNano
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1615:
URL: https://github.com/apache/arrow-datafusion/pull/1615#issuecomment-1018212649
Thank you @ovr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp merged pull request #1615: feat: Support complex interval via IntervalMonthDayNano
Posted by GitBox <gi...@apache.org>.
houqp merged pull request #1615:
URL: https://github.com/apache/arrow-datafusion/pull/1615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1615: feat: Support complex interval via IntervalMonthDayNano
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1615:
URL: https://github.com/apache/arrow-datafusion/pull/1615#discussion_r789166757
##########
File path: datafusion/tests/sql/expr.rs
##########
@@ -496,6 +498,24 @@ async fn test_interval_expressions() -> Result<()> {
"interval '2' year",
"2 years 0 mons 0 days 0 hours 0 mins 0.00 secs"
);
+ // complex
Review comment:
👍 nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org