You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/20 08:33:03 UTC
[GitHub] [incubator-nuttx] aenrbes opened a new pull request #595: Support
for Litex VexRiscV
aenrbes opened a new pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595
Add initial support for Litex with softcore CPU VexRiscV SoC [LiteX's website](https://github.com/enjoy-digital/litex), device drivers such as GPIO/I2C/SPI are missing.
Note that Litex vexriscv has a rom bootloader integrated in fpga gateware, it load image from tftp/flash to on board ddr3.
The ostest passed. Basic nsh commands such as uname/ps/free/sleep work fine.Tested on Digilent ARTY_A7 board.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601651338
@Ouss4 do we have a Github PR/Issue template (and access to it) we can add all this info to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] aenrbes edited a comment on issue #595: Support
for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
aenrbes edited a comment on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601648755
@Ouss4 Thank you, does this mean I need to change all submitted files like that templates does？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #595:
Support for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395554042
##########
File path: .gitignore
##########
@@ -30,3 +30,5 @@ core
/.project
/tags
/TAGS
+.vscode/settings.json
+.vscode/c_cpp_properties.json
Review comment:
I don't think that editor specific files belong to the top level .gitignore.
You can ignore them locally.
@patacongo what's your take?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] justinmclean commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
justinmclean commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601673984
Please refer to [1] which contains the correct text.
1. https://www.apache.org/legal/src-headers.html#headers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #595: Support for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395652215
##########
File path: .gitignore
##########
@@ -29,4 +29,4 @@ core
/.cproject
/.project
/tags
-/TAGS
+/TAGS
Review comment:
Just saw the new change, the PR looks fine now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #595: Support for Litex
VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601636436
@aenrbes Nice!
Since this is a new contribution (all new files) the licences needs to be the Apache one (@Ouss4 is there a template or instructions?) and an the contributor will need to submit an ICLA https://www.apache.org/licenses/icla.pdf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #595: Support
for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601669239
The required form, the "template", is in the appendix to the coding standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #595: Support for Litex
VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601657889
@aenrbs New files need to have an Apache license. Kconfig, README and auto generated files like defconfig don't need a license.
Note that the license holder in all of this PRs files is Gregory Nutt. Gregory Nutt has already submitted an ICLA and gave his approval to change his license header.
@davids5 As of now, we don't. Some has adopted their own templates when submitting PRs.
We may want to add Github's templates for PRs/Issues. Maybe we bring this to the dev list for a discussion on what should be there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #595: Support for Litex
VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601795244
I think the PR looks good and is ready to merge. Let's give some time for anyone that wants to add any review.
When merging, I'd like to squash the 5 commits into one.
I'll not bring the PR locally and do the squashing manually, I'll squash from Github.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #595: Support for Litex
VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601645329
A template for the Apache license?
Here is one https://github.com/apache/incubator-nuttx/blob/master/sched/sched/sched_getcpu.c
The LICENSE file also has [an example.](https://github.com/apache/incubator-nuttx/blob/master/LICENSE#L191)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] aenrbes commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
aenrbes commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601648755
@Ouss4 Thank you, does this means I need to change all submitted files like that templates does？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #595:
Support for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395678532
##########
File path: arch/risc-v/src/litex/hardware/litex_plic.h
##########
@@ -0,0 +1,34 @@
+/****************************************************************************
+ * arch/risc-v/src/litex/hardware/litex_plic.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_RISCV_SRC_LITEX_HARDWARE_LITEX_PLIC_H
+#define __ARCH_RISCV_SRC_LITEX_HARDWARE_LITEX_PLIC_H
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* litex vexRiscv does not follow RISC-V privileged specification and
+ * uses two additional CSRs: mask and pending.
+ */
Review comment:
```suggestion
*/
```
Not sure why nxstyle didn't pick this one up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #595:
Support for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395690203
##########
File path: arch/risc-v/src/litex/hardware/litex_plic.h
##########
@@ -0,0 +1,35 @@
+/****************************************************************************
+ * arch/risc-v/src/litex/hardware/litex_plic.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_RISCV_SRC_LITEX_HARDWARE_LITEX_PLIC_H
+#define __ARCH_RISCV_SRC_LITEX_HARDWARE_LITEX_PLIC_H
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* litex vexRiscv does not follow RISC-V privileged specification and
+ * uses two additional CSRs: mask and pending.
+ */
+
Review comment:
```suggestion
```
That must have been introduced by my Code suggestion. Sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 edited a comment on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601657889
@aenrbes New files need to have an Apache license. Kconfig, README and auto generated files like defconfig don't need a license.
Note that the license holder in all of this PRs files is Gregory Nutt. Gregory Nutt has already submitted an ICLA and gave his approval to change his license header.
@davids5 As of now, we don't. Some has adopted their own templates when submitting PRs.
We may want to add Github's templates for PRs/Issues. Maybe we bring this to the dev list for a discussion on what should be there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601669239
The required form, the "teplate", is in the teplate to the coding standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601684165
@Ouss4 - Thank you for the direct links!
> We may want to add Github's templates for PRs/Issues. Maybe we bring this to the dev list for a discussion on what should be there?
@Ouss4 - email sent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for
Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601685210
@justinmclean - Does you answer imply that the information given was incorrect or the contributor has it wrong or were you just giving an alternate source?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #595: Support for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395628518
##########
File path: .gitignore
##########
@@ -29,4 +29,4 @@ core
/.cproject
/.project
/tags
-/TAGS
+/TAGS
Review comment:
revert the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] aenrbes commented on a change in pull request
#595: Support for Litex VexRiscV
Posted by GitBox <gi...@apache.org>.
aenrbes commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395650578
##########
File path: .gitignore
##########
@@ -29,4 +29,4 @@ core
/.cproject
/.project
/tags
-/TAGS
+/TAGS
Review comment:
I already fix it, and did a force push.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services