You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/24 12:01:22 UTC
[GitHub] [incubator-nuttx] cwespressif opened a new pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
cwespressif opened a new pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603
## Summary
Reconnect AP(Access Point) according to the scan results.
## Impact
Make Wi-Fi reconnect more effective.
## Testing
After the AP(Access Point) is powered off, the device will disconnect from the AP and then make AP(Access Point) power on
, the device will reconnect according to the scan results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826334986
> > This sounds convenient but I wonder if such thing shouldn't normally be handled in userspace (with something like the net monitor). Otherwise this functionality must be replicated in every wifi driver.
>
> Hi @v01d thanks for your comments, it can be implemented in userspace, but it is more troublesome to get Wi-Fi driver status in userspace: the user needs to understand the Wi-Fi status event in the kernel first, and then implement it, maybe I think it would be more reasonable for us to do this in the kernel.
> The similar net monitor is only for network, unless we can define a set of WiFi events monitor, because the WiFi status events may be different for each manufacturer, it will be more troublesome to do so, what do you think ?
My understanding is that you subscribe to events from the network driver, which is what the netmonitor does. I did not think about lack of standardization across drivers, is that an issue right now? If so, it is probably worth it to define at least a set of standard events that most drivers would support. This should be enough to monitor a connection and reconnect upon loss.
In any case, I do not oppose to the change in the meantime. I would simply try to not overcomplicate this driver since as you see it already requires replicating the behavior for ESP32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826111665
This sounds convenient but I wonder if such thing shouldn't normally be handled in userspace (with something like the net monitor). Otherwise this functionality must be replicated in every wifi driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cwespressif closed pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
cwespressif closed pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cwespressif commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-834119086
Considering that it is better for Wi-Fi scan to reconnect in the application rather than in the Wi-Fi driver, I will close this PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cwespressif commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826247899
> Hi @cwespressif why don't we have a CONFIG_ESP32_SCAN_TO_RECONNECT too?
Hi @acassis I will add it in ESP32 later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826084976
Hi @cwespressif why we don't have a CONFIG_ESP32_SCAN_TO_RECONNECT too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cwespressif commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826456612
> > > This sounds convenient but I wonder if such thing shouldn't normally be handled in userspace (with something like the net monitor). Otherwise this functionality must be replicated in every wifi driver.
> >
> >
> > Hi @v01d thanks for your comments, it can be implemented in userspace, but it is more troublesome to get Wi-Fi driver status in userspace: the user needs to understand the Wi-Fi status event in the kernel first, and then implement it, maybe I think it would be more reasonable for us to do this in the kernel.
> > The similar net monitor is only for network, unless we can define a set of WiFi events monitor, because the WiFi status events may be different for each manufacturer, it will be more troublesome to do so, what do you think ?
>
> My understanding is that you subscribe to events from the network driver, which is what the netmonitor does. I did not think about lack of standardization across drivers, is that an issue right now? If so, it is probably worth it to define at least a set of standard events that most drivers would support. This should be enough to monitor a connection and reconnect upon loss.
>
> In any case, I do not oppose to the change in the meantime. I would simply try to not overcomplicate this driver since as you see it already requires replicating the behavior for ESP32.
Yes, currently the NuttX wireless driver interface only supports WEXT, and the WEXT driver that uses ioctl lacks the function of getting the event of the wireless driver, As far as I know, the wireless driver generally uses two standard interfaces: WEXT and NL80211
If we need to support the standard events supported by the wireless driver, we'd better support NL80211: https://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git/tree/include/uapi/linux/nl80211.h
**I** agree with you about trying not to make the driver too complicated, but NuttX has very limited wireless driver functions, at least in my opinion, the WEXT ioctl method is difficult to cover wireless driver applications, so I implemented this function in the kernel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826084976
Hi @cwespressif why don't we have a CONFIG_ESP32_SCAN_TO_RECONNECT too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826084976
Hi @cwespressif why we don't have a CONFIG_ESP32_SCAN_TO_RECONNECT too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cwespressif commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826249785
> This sounds convenient but I wonder if such thing shouldn't normally be handled in userspace (with something like the net monitor). Otherwise this functionality must be replicated in every wifi driver.
Hi @v01d thanks for your comments, it can be implemented in userspace, but it is more troublesome to get Wi-Fi driver status in userspace: the user needs to understand the Wi-Fi status event in the kernel first, and then implement it, maybe I think it would be more reasonable for us to do this in the kernel.
The similar net monitor is only for network, unless we can define a set of WiFi events monitor, because the WiFi status events may be different for each manufacturer, it will be more troublesome to do so, what do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826111665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826084976
Hi @cwespressif why don't we have a CONFIG_ESP32_SCAN_TO_RECONNECT too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cwespressif commented on pull request #3603: risc-v/esp32c3: Support Wi-Fi scan to reconnect
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #3603:
URL: https://github.com/apache/incubator-nuttx/pull/3603#issuecomment-826247899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org