You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apr.apache.org by Paul Querna <pa...@querna.org> on 2009/09/01 01:26:52 UTC

Re: svn commit: r809745 - /apr/apr/trunk/configure.in

On Mon, Aug 31, 2009 at 2:13 PM, <ji...@apache.org> wrote:
> Author: jim
> Date: Mon Aug 31 21:13:24 2009
> New Revision: 809745
>
> URL: http://svn.apache.org/viewvc?rev=809745&view=rev
> Log:
> This is the right one...
>
> Fix APR_OFF_T_FMT which is lld for OS X 10.6 (darwin 10.0.0)
> since off_t ends up as a long long.
>
> Modified:
>    apr/apr/trunk/configure.in
>

Doesn't this belong in apr_hints.m4:
<https://svn.apache.org/repos/asf/apr/apr/trunk/build/apr_hints.m4>
?

Re: svn commit: r809745 - /apr/apr/trunk/configure.in

Posted by Jim Jagielski <ji...@jaguNET.com>.

On Aug 31, 2009, at 7:26 PM, Paul Querna wrote:

> On Mon, Aug 31, 2009 at 2:13 PM, <ji...@apache.org> wrote:
>> Author: jim
>> Date: Mon Aug 31 21:13:24 2009
>> New Revision: 809745
>>
>> URL: http://svn.apache.org/viewvc?rev=809745&view=rev
>> Log:
>> This is the right one...
>>
>> Fix APR_OFF_T_FMT which is lld for OS X 10.6 (darwin 10.0.0)
>> since off_t ends up as a long long.
>>
>> Modified:
>>    apr/apr/trunk/configure.in
>>
>
> Doesn't this belong in apr_hints.m4:
> <https://svn.apache.org/repos/asf/apr/apr/trunk/build/apr_hints.m4>
> ?
>

The full fix does, I think, but it required more work* than I
had time for at present, so I went ahead and adjusted configure.in
as we do with size_t_fmt

*The current code for the off_t_fmt check doesn't initially
check if off_t_fmt is already set, which is what hints needs
to work (since hints runs pretty much at the start)