[GitHub] [iceberg] rdblue commented on a diff in pull request #5309: #5308 - Avoid 2 reads on manifest

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5309:
URL: https://github.com/apache/iceberg/pull/5309#discussion_r925114650


##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -249,9 +249,11 @@ public CloseableIterator<T> iterator() {
                 .caseSensitive(caseSensitive)
                 .select(columns);
 
-            CloseableIterable<ManifestEntry<DataFile>> entries = reader.entries();
+            CloseableIterable<ManifestEntry<DataFile>> entries = null;

Review Comment:
   You can omit the `= null` in this case because it is set in all control flow branches below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org