You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/08 03:02:48 UTC
[GitHub] [apisix-website] CP3cham opened a new pull request #870: chore:add the LTS download button of 'apisix'
CP3cham opened a new pull request #870:
URL: https://github.com/apache/apisix-website/pull/870
Changes:
add the LTS download button of 'apisix'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 7c2ecd98ddc12ca3ae4109155b16b0566d8f59d7
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620cce452f5e070007b6e209](https://app.netlify.com/sites/apache-apisix/deploys/620cce452f5e070007b6e209)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 138685d28d83d0e3887efecbaf33f9df23378bc9
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620470e751d9180008f87069](https://app.netlify.com/sites/apache-apisix/deploys/620470e751d9180008f87069)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: d39110b4349ba002ba2095ce4cd3e0c97f9dca84
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620f45abaef07f000758ed40](https://app.netlify.com/sites/apache-apisix/deploys/620f45abaef07f000758ed40)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1039745712
@guoqqqi If some conversations are resolved, please click "Resolve".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1039745712
@guoqqqi If some conversations are resolved, please click "Recolve".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r808809878
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -70,6 +94,18 @@ const ProjectCard = (props) => {
});
}, []);
+ const LTSButton = () => {
+ return (
+ <Button
+ style={{ display: (name === 'APISIXยฎ' ? ' ' : 'NONE') }}
+ onClick={() => setIsLTSDropdownOpen(!isLTSDropdownOpen)}
+ background={color}
+ >
+ <IconDownload /> 2.10.3 LTS
Review comment:
ditto
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -44,8 +64,12 @@ const ProjectCard = (props) => {
releaseDate,
githubRepo,
githubBranch,
- downloadPath
+ downloadPath,
+ LTSDownloadPath = ' '
} = props;
+
+ const Download = props.name === 'APISIXยฎ' ? '2.12.1 Current' : 'Download'
Review comment:
Should I use the data from `downloads.js`? To avoid the need to also modify the js file for each update, not every one of us releaser knows the frontend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] oil-oil commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
oil-oil commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1042710686
I think it is more appropriate to move the dropdown box from the **upper right** corner of the button to the **lower left** corner. I feel a little weird now.
<img width="427" alt="image" src="https://user-images.githubusercontent.com/57465570/154439352-42992cfb-b8fb-4f43-9a14-6c5bf08c1fae.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: ab05b0c9ce145c3de90c5b5bcc1127bc7a93aa7f
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620ccbe51e26240007650d95](https://app.netlify.com/sites/apache-apisix/deploys/620ccbe51e26240007650d95)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1033784867
cc @CP3cham ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1039745712
@guoqqqi If some conversations are resolved, please click "Recolve".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1041200234
Hi, @CP3cham Can you help me with the resolved commit click "Resolve" as I see that the ones I commented on have been corrected~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] zaunist edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
zaunist edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1034425318
It looks like to need sync master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 1e61c18af833d30556bad3ef432e2fe1db3593aa
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6201dd509d7ed20008e1ee3a](https://app.netlify.com/sites/apache-apisix/deploys/6201dd509d7ed20008e1ee3a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r808809878
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -70,6 +94,18 @@ const ProjectCard = (props) => {
});
}, []);
+ const LTSButton = () => {
+ return (
+ <Button
+ style={{ display: (name === 'APISIXยฎ' ? ' ' : 'NONE') }}
+ onClick={() => setIsLTSDropdownOpen(!isLTSDropdownOpen)}
+ background={color}
+ >
+ <IconDownload /> 2.10.3 LTS
Review comment:
ditto, and need to update to the latest version 2.10.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 7c2ecd98ddc12ca3ae4109155b16b0566d8f59d7
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620cce452f5e070007b6e209](https://app.netlify.com/sites/apache-apisix/deploys/620cce452f5e070007b6e209)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1041002612
> @guoqqqi If some conversations are resolved, please click "Resolve".
I can't click Resolve yet ๐
![image](https://user-images.githubusercontent.com/72343596/154179597-e5b526fc-5649-4124-8949-e8ae5ba03632.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 65124f1394b1bf9ce175839f07d7e3c05bc4e3d1
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6204e29222306600080c6e33](https://app.netlify.com/sites/apache-apisix/deploys/6204e29222306600080c6e33)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 65124f1394b1bf9ce175839f07d7e3c05bc4e3d1
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6204e29222306600080c6e33](https://app.netlify.com/sites/apache-apisix/deploys/6204e29222306600080c6e33)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r806367673
##########
File path: website/config/downloads.js
##########
@@ -7,10 +7,10 @@ module.exports = [
color: "#e8433e",
githubRepo: "apache/apisix",
githubBranch: "master",
- downloadPath: "apisix/2.11.0/apache-apisix-2.11.0-src",
- version: "2.11.0",
+ downloadPath: "apisix/2.12.1/apache-apisix-2.12.1-src",
Review comment:
Please be careful on this, make sure using the latest links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] zaunist commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1037329677
@CP3cham Could you merge the master branch?
![image](https://user-images.githubusercontent.com/38528079/153721439-b1a14f49-5a24-4cb7-8c79-0c61fbf7b79b.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r805158711
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -13,6 +13,7 @@ import IconStarSolid from "../../assets/icons/star-solid.svg";
import IconOctagon from "../../assets/icons/octagon.svg";
import IconShield from "../../assets/icons/shield.svg";
+
Review comment:
Remove the extra line
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -46,6 +68,10 @@ const ProjectCard = (props) => {
githubBranch,
downloadPath
} = props;
+
+ const Download=props.name==='APISIXยฎ'?'2.11.0 Current':'Download'
Review comment:
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] zaunist commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1037329677
@CP3cham Could you merge the master branch?
![image](https://user-images.githubusercontent.com/38528079/153721439-b1a14f49-5a24-4cb7-8c79-0c61fbf7b79b.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 merged pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
bzp2010 merged pull request #870:
URL: https://github.com/apache/apisix-website/pull/870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r801345719
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -46,6 +68,10 @@ const ProjectCard = (props) => {
githubBranch,
downloadPath
} = props;
+
+ const Download=props.name==='APISIXยฎ'?'2.11.0 Current':'Download'
+
+
Review comment:
```suggestion
```
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -13,6 +13,7 @@ import IconStarSolid from "../../assets/icons/star-solid.svg";
import IconOctagon from "../../assets/icons/octagon.svg";
import IconShield from "../../assets/icons/shield.svg";
+
Review comment:
```suggestion
```
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -70,6 +97,23 @@ const ProjectCard = (props) => {
});
}, []);
+
+
+
+ const LTSButton=()=>{
+
+ return(
+ <Button
+ style={{display: (name==='APISIXยฎ'? ' ':'NONE')}}
+ onClick={() => setIsLTSDropdownOpen(!isLTSDropdownOpen)}
+ background={color}
+ >
+ <IconDownload /> 2.10.3 LTS
+ </Button>
+ )
+ }
+
+
Review comment:
Please format the code
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -258,6 +356,8 @@ const RightSide = styled.div`
padding-left: 0;
}
`;
+
Review comment:
ditto
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -46,6 +68,10 @@ const ProjectCard = (props) => {
githubBranch,
downloadPath
} = props;
+
+ const Download=props.name==='APISIXยฎ'?'2.11.0 Current':'Download'
Review comment:
```suggestion
const Download = props.name ==='APISIXยฎ' ? '2.11.0 Current' : 'Download'
```
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -231,6 +311,12 @@ const LeftSideLinks = styled.div`
margin-right: 4px;
}
`;
+const ButtonRow=styled.div`
+ inline-size:auto;
+ display: flex;
+
Review comment:
ditto
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -70,6 +97,23 @@ const ProjectCard = (props) => {
});
}, []);
+
+
+
Review comment:
We don't need extra blank lines
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -32,7 +33,28 @@ const Dropdown = (props) => {
);
};
+const LTSDropdown = (props) => {
+ const ref = useRef();
+ const { isLTSDropdownOpen, setIsLTSDropdownOpen } = props;
+ useOutsideClick(ref, () => {
+ if (isLTSDropdownOpen) {
+ setIsLTSDropdownOpen(false);
+ }
+ });
+ return (
+ <StyledDropdown
+ className="downloads-dropdown"
+ ref={ref}
+ open={isLTSDropdownOpen}
+ >
+ {props.children}
+ </StyledDropdown>
+ );
+};
+
+
Review comment:
```suggestion
```
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -112,12 +156,47 @@ const ProjectCard = (props) => {
Release Date ยท{" "}
<span className="downloads-versioninfo-span">{releaseDate}</span>
</VersionInfo>
- <div>
+
+ <ButtonRow>
+ <LTSCard>
+ <LTSButton />
+ <LTSDropdown
+ isLTSDropdownOpen={isLTSDropdownOpen}
+ setIsLTSDropdownOpen={setIsLTSDropdownOpen}
+ >
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz`}
+ target="_blank"
+ >
+ Source
+ </DropdownItem>
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz.asc`}
+ target="_blank"
+ >
+ ASC
+ </DropdownItem>
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz.sha512`}
+ target="_blank"
+ >
+ SHA512
+ </DropdownItem>
+ </LTSDropdown>
+ </LTSCard>
+
+
+
+ <ButtonCard>
<Button
+
Review comment:
ditto
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -112,12 +156,47 @@ const ProjectCard = (props) => {
Release Date ยท{" "}
<span className="downloads-versioninfo-span">{releaseDate}</span>
</VersionInfo>
- <div>
+
+ <ButtonRow>
+ <LTSCard>
+ <LTSButton />
+ <LTSDropdown
+ isLTSDropdownOpen={isLTSDropdownOpen}
+ setIsLTSDropdownOpen={setIsLTSDropdownOpen}
+ >
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz`}
+ target="_blank"
+ >
+ Source
+ </DropdownItem>
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz.asc`}
+ target="_blank"
+ >
+ ASC
+ </DropdownItem>
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz.sha512`}
+ target="_blank"
+ >
+ SHA512
+ </DropdownItem>
+ </LTSDropdown>
+ </LTSCard>
+
+
+
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r803246891
##########
File path: website/config/downloads.js
##########
@@ -9,6 +9,7 @@ module.exports = [
githubBranch: "master",
downloadPath: "apisix/2.11.0/apache-apisix-2.11.0-src",
version: "2.11.0",
+ LTSDownloadPath:"2.10.3",
Review comment:
It looks more like `LTSVersion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi edited a comment on pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1033784867
@CP3cham ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r802195668
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -112,12 +156,47 @@ const ProjectCard = (props) => {
Release Date ยท{" "}
<span className="downloads-versioninfo-span">{releaseDate}</span>
</VersionInfo>
- <div>
+
+ <ButtonRow>
+ <LTSCard>
+ <LTSButton />
+ <LTSDropdown
+ isLTSDropdownOpen={isLTSDropdownOpen}
+ setIsLTSDropdownOpen={setIsLTSDropdownOpen}
+ >
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz`}
Review comment:
As the version is updated we may need to be more flexible with this link?๐ค
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: f3f46025622e11a7454f5859623e5019866e34e3
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723](https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 1e61c18af833d30556bad3ef432e2fe1db3593aa
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6201dd509d7ed20008e1ee3a](https://app.netlify.com/sites/apache-apisix/deploys/6201dd509d7ed20008e1ee3a)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 138685d28d83d0e3887efecbaf33f9df23378bc9
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620470e751d9180008f87069](https://app.netlify.com/sites/apache-apisix/deploys/620470e751d9180008f87069)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r803695711
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -318,4 +408,4 @@ const VersionInfo = styled.div`
}
`;
-export default ProjectCard;
+export default ProjectCard;
Review comment:
Usually we need to add a new blank line at the end of the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 29d2a4e624e94843c059080addb385f17e9e24fa
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6208f27403601600071a20df](https://app.netlify.com/sites/apache-apisix/deploys/6208f27403601600071a20df)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1039745712
@guoqqqi If some conversations are resolved, please click "Resolve".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 0416814fa22cf554afd03c2ae2c5c660366e09c1
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6209f62c71a4ed0007baef5a](https://app.netlify.com/sites/apache-apisix/deploys/6209f62c71a4ed0007baef5a)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 6cb36b6a253b06ce39364165618143d05150d4ef
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62090169ab75090008043300](https://app.netlify.com/sites/apache-apisix/deploys/62090169ab75090008043300)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 4c7ffc4f130a78eba009eec76bb00944a2117452
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620f3e061486010008d76cfd](https://app.netlify.com/sites/apache-apisix/deploys/620f3e061486010008d76cfd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r805158711
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -13,6 +13,7 @@ import IconStarSolid from "../../assets/icons/star-solid.svg";
import IconOctagon from "../../assets/icons/octagon.svg";
import IconShield from "../../assets/icons/shield.svg";
+
Review comment:
Remove the extra line
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -46,6 +68,10 @@ const ProjectCard = (props) => {
githubBranch,
downloadPath
} = props;
+
+ const Download=props.name==='APISIXยฎ'?'2.11.0 Current':'Download'
Review comment:
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r806367673
##########
File path: website/config/downloads.js
##########
@@ -7,10 +7,10 @@ module.exports = [
color: "#e8433e",
githubRepo: "apache/apisix",
githubBranch: "master",
- downloadPath: "apisix/2.11.0/apache-apisix-2.11.0-src",
- version: "2.11.0",
+ downloadPath: "apisix/2.12.1/apache-apisix-2.12.1-src",
Review comment:
Please be careful on this, make sure using the latest links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: ab05b0c9ce145c3de90c5b5bcc1127bc7a93aa7f
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620ccbe51e26240007650d95](https://app.netlify.com/sites/apache-apisix/deploys/620ccbe51e26240007650d95)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 6cb36b6a253b06ce39364165618143d05150d4ef
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62090169ab75090008043300](https://app.netlify.com/sites/apache-apisix/deploys/62090169ab75090008043300)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1039063286
Hi, @CP3cham Please add an image to the description area to make it easier for everyone to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: 0416814fa22cf554afd03c2ae2c5c660366e09c1
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6209f62c71a4ed0007baef5a](https://app.netlify.com/sites/apache-apisix/deploys/6209f62c71a4ed0007baef5a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] zaunist commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1034425318
It look like need to sync master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
๐ท Deploy Preview for *apache-apisix* processing.
๐จ Explore the source changes: f3f46025622e11a7454f5859623e5019866e34e3
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723](https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 29d2a4e624e94843c059080addb385f17e9e24fa
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6208f27403601600071a20df](https://app.netlify.com/sites/apache-apisix/deploys/6208f27403601600071a20df)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] CP3cham commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
CP3cham commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1043970660
> > I think it is more appropriate to move the dropdown box from the **upper right** corner of the button to the **lower left** corner. I feel a little weird now.
> > <img alt="image" width="427" src="https://user-images.githubusercontent.com/57465570/154439352-42992cfb-b8fb-4f43-9a14-6c5bf08c1fae.png">
>
> ok,I will resolve it
Like this
![image](https://user-images.githubusercontent.com/87352162/154627724-066b59bf-3b11-4ac6-9afb-e2de4d473e34.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] CP3cham commented on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
CP3cham commented on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1043960051
> I think it is more appropriate to move the dropdown box from the **upper right** corner of the button to the **lower left** corner. I feel a little weird now.
>
> <img alt="image" width="427" src="https://user-images.githubusercontent.com/57465570/154439352-42992cfb-b8fb-4f43-9a14-6c5bf08c1fae.png">
ok,I will resolve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: 4c7ffc4f130a78eba009eec76bb00944a2117452
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620f3e061486010008d76cfd](https://app.netlify.com/sites/apache-apisix/deploys/620f3e061486010008d76cfd)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360
โ๏ธ Deploy Preview for *apache-apisix* ready!
๐จ Explore the source changes: d39110b4349ba002ba2095ce4cd3e0c97f9dca84
๐ Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620f45abaef07f000758ed40](https://app.netlify.com/sites/apache-apisix/deploys/620f45abaef07f000758ed40)
๐ Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] CP3cham commented on a change in pull request #870: chore:add the LTS download button of 'apisix'
Posted by GitBox <gi...@apache.org>.
CP3cham commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r802757739
##########
File path: website/src/pages/downloads/ProjectCard.js
##########
@@ -112,12 +156,47 @@ const ProjectCard = (props) => {
Release Date ยท{" "}
<span className="downloads-versioninfo-span">{releaseDate}</span>
</VersionInfo>
- <div>
+
+ <ButtonRow>
+ <LTSCard>
+ <LTSButton />
+ <LTSDropdown
+ isLTSDropdownOpen={isLTSDropdownOpen}
+ setIsLTSDropdownOpen={setIsLTSDropdownOpen}
+ >
+ <DropdownItem
+ className="download-dropdown-item"
+ href={`https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz`}
Review comment:
Yep,maybe the version info can be put in the json file which include all version info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org