You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/02/24 20:34:22 UTC
[kudu-CR] build-and-test: pass Gradle args to kudu subprocess
Hello Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15282
to review the following change.
Change subject: build-and-test: pass Gradle args to kudu_subprocess
......................................................................
build-and-test: pass Gradle args to kudu_subprocess
20be5d957ab80c7c0ed8eaf62324ac70940d7543 added Gradle to the C++ build.
Following the precidence of bde730f6ba8f90893604edcdd803191d4f0a5d4d,
this disables the Gradle daemon and passes other Gradle args that we use
for the Java build.
Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
---
M build-support/jenkins/build-and-test.sh
M src/kudu/subprocess/CMakeLists.txt
2 files changed, 16 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15282/1
--
To view, visit http://gerrit.cloudera.org:8080/15282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Gerrit-Change-Number: 15282
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] build-and-test: pass Gradle args to kudu subprocess
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15282 )
Change subject: build-and-test: pass Gradle args to kudu_subprocess
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15282/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15282/1//COMMIT_MSG@10
PS1, Line 10: precidence
precedence
--
To view, visit http://gerrit.cloudera.org:8080/15282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Gerrit-Change-Number: 15282
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 Feb 2020 20:41:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test: pass Gradle args to kudu subprocess
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15282
to look at the new patch set (#2).
Change subject: build-and-test: pass Gradle args to kudu_subprocess
......................................................................
build-and-test: pass Gradle args to kudu_subprocess
20be5d957ab80c7c0ed8eaf62324ac70940d7543 added Gradle to the C++ build.
Following the precedence of bde730f6ba8f90893604edcdd803191d4f0a5d4d,
this disables the Gradle daemon and passes other Gradle args that we use
for the Java build.
Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
---
M build-support/jenkins/build-and-test.sh
M src/kudu/subprocess/CMakeLists.txt
2 files changed, 16 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15282/2
--
To view, visit http://gerrit.cloudera.org:8080/15282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Gerrit-Change-Number: 15282
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build-and-test: pass Gradle args to kudu subprocess
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15282 )
Change subject: build-and-test: pass Gradle args to kudu_subprocess
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15282/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15282/1//COMMIT_MSG@10
PS1, Line 10: precedence
> precedence
Done
--
To view, visit http://gerrit.cloudera.org:8080/15282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Gerrit-Change-Number: 15282
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 Feb 2020 20:41:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test: pass Gradle args to kudu subprocess
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15282 )
Change subject: build-and-test: pass Gradle args to kudu_subprocess
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Gerrit-Change-Number: 15282
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 Feb 2020 20:47:34 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test: pass Gradle args to kudu subprocess
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15282 )
Change subject: build-and-test: pass Gradle args to kudu_subprocess
......................................................................
build-and-test: pass Gradle args to kudu_subprocess
20be5d957ab80c7c0ed8eaf62324ac70940d7543 added Gradle to the C++ build.
Following the precedence of bde730f6ba8f90893604edcdd803191d4f0a5d4d,
this disables the Gradle daemon and passes other Gradle args that we use
for the Java build.
Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Reviewed-on: http://gerrit.cloudera.org:8080/15282
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
M src/kudu/subprocess/CMakeLists.txt
2 files changed, 16 insertions(+), 12 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3732488106b813cca1486647dc8c3d7c68fb859
Gerrit-Change-Number: 15282
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)