[jira] [Commented] (TINKERPOP-932) Add ability to cancel script execution associated with a Gremlin Server Session

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603167#comment-15603167 ] 

ASF GitHub Bot commented on TINKERPOP-932:
------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/461

    TINKERPOP-932 Added "force" option on session close.

    https://issues.apache.org/jira/browse/TINKERPOP-932
    
    Allows session close requests to interrupt a long run job at the cost of not closing transactions.
    
    Tested with: `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-932

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #461
    
----

----


> Add ability to cancel script execution associated with a Gremlin Server Session 
> --------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-932
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-932
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.0.2-incubating
>            Reporter: Zachary Kurey
>            Assignee: stephen mallette
>             Fix For: 3.2.4
>
>
> Currently with a {{SessionedClient}} there is no way to cancel a long running script and the client has to depend on Gremlin Server side configured timeouts before they can execute another script associated with the same session id.
> There is a way we can forcefully close a session from the client side, or just close the entire Gremlin client.  But it would be useful for client side applications to be able to cancel script execution, have its intermediate effects rolled back, and be able to continue interacting with the session without losing session variable state maintained on the Gremlin server side.
> Unsure where this should live at an API level, since canceling by session id isn't relevant for all {{Client}} implementations.  If somehow when the {{CompletableFuture<ResultSet>}} returned by {{Client.submitAsync}} could do this when the {{Future}} is canceled, that would be a nice way to bridge implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)