You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/09/28 14:05:00 UTC
[GitHub] [echarts] sirAbramstone opened a new issue, #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
sirAbramstone opened a new issue, #17712:
URL: https://github.com/apache/echarts/issues/17712
### Version
5.4.0
### Link to Minimal Reproduction
https://codepen.io/Pikcher/pen/xxjYqMQ
### Steps to Reproduce
1. Chart creates as usual: `echarts.init(container); instance.setOption(options);`.
2. Options:
```
options = {
series: [{
type: 'pie',
radius: ['40%', '70%'],
minShowLabelAngle: 100,
label: {
show: true,
position: 'inside',
},
data: [
{ value: 1048, name: 'Search Engine' },
{ value: 735, name: 'Direct' },
{ value: 580, name: 'Email' },
{ value: 484, name: 'Union Ads' },
{ value: 300, name: 'Video Ads' }
]
}]
}
```
3. Problem become visible immediately after widget's initialisation
### Current Behavior
Function "pieLabelLayout" that's placed in lib/chart/pie/labelLayout.js bring about code execution failure with error: `TypeError: Cannot read properties of undefined (reading 'states')`. It happens when chart has options pie-series.minShowLabelAngle and pie-series.label.position === 'inside' or pie-series.label.position === 'inner' together. You can see labels that should be hidden display in top left corner of the chart.
<img width="604" alt="image" src="https://user-images.githubusercontent.com/30146267/192799952-73ae2398-0082-41d0-8223-23f270ebc9ed.png">
### Expected Behavior
Labels should not be displayed according to the minShowLabelAngle setting.
### Environment
```markdown
- OS: macOS Monterey
- Browser: Chrome 105.0.5195.125
- Framework: Vue@2
```
### Any additional comments?
It seems like bug appears in version 5.4.0., I did't watch that behavior in previous minor version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sirAbramstone commented on issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
Posted by GitBox <gi...@apache.org>.
sirAbramstone commented on issue #17712:
URL: https://github.com/apache/echarts/issues/17712#issuecomment-1261859991
@plainheart thank you, I'll really appreciate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia closed issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
Posted by GitBox <gi...@apache.org>.
Ovilia closed issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
URL: https://github.com/apache/echarts/issues/17712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #17712:
URL: https://github.com/apache/echarts/issues/17712#issuecomment-1261724338
@sirAbramstone I'm sorry about this bug. If it's serious and is a blocker for your project, you can do a patch for current package or use today's nightly version later.
```sh
npm i echarts@npm:echarts-nightly@5.4.1-dev.20220929
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #17712:
URL: https://github.com/apache/echarts/issues/17712#issuecomment-1261716735
This issue is labeled with `priority: high`, which means it's a frequently asked problem and we will fix it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] wilnerjs commented on issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
Posted by GitBox <gi...@apache.org>.
wilnerjs commented on issue #17712:
URL: https://github.com/apache/echarts/issues/17712#issuecomment-1263082531
> @sirAbramstone I'm sorry about this bug. If it's serious and is a blocker for your project, you can do a patch for current package or use today's nightly version later.
>
> ```shell
> npm i echarts@npm:echarts-nightly@5.4.1-dev.20220929
> ```
@plainheart thks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #17712: [Bug] Pie chart: minShowLabelAngle and label.position break down together
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #17712:
URL: https://github.com/apache/echarts/issues/17712#issuecomment-1261690528
Thanks for your feedback! This is an unexpected error brought by #17412. The `labelLine` may be undefined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org