You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/01 16:35:00 UTC
[jira] [Work logged] (HIVE-23365) Put RS deduplication optimization
under cost based decision
[ https://issues.apache.org/jira/browse/HIVE-23365?focusedWorklogId=439593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439593 ]
ASF GitHub Bot logged work on HIVE-23365:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/20 16:34
Start Date: 01/Jun/20 16:34
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1035:
URL: https://github.com/apache/hive/pull/1035#discussion_r433349779
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplicationUtils.java
##########
@@ -197,6 +186,27 @@ public static boolean merge(ReduceSinkOperator cRS, ReduceSinkOperator pRS, int
return true;
}
+ private static long estimateReducers(HiveConf conf, ReduceSinkOperator rs) {
+ // TODO: Check if we can somehow exploit the logic in SetReducerParallelism
+ if (rs.getConf().getNumReducers() > 0) {
+ return rs.getConf().getNumReducers();
+ }
+ int constantReducers = conf.getIntVar(HiveConf.ConfVars.HADOOPNUMREDUCERS);
+ if (constantReducers > 0) {
+ return constantReducers;
+ }
+ long inputTotalBytes = 0;
+ List<Operator<?>> rsSiblings = rs.getChildOperators().get(0).getParentOperators();
+ for (Operator<?> sibling : rsSiblings) {
+ if (sibling.getStatistics() != null) {
Review comment:
I am wondering, if you do not have stats available for any of the siblings, we should probably skip the parallelism check, and thus, fallback to previous behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 439593)
Time Spent: 40m (was: 0.5h)
> Put RS deduplication optimization under cost based decision
> -----------------------------------------------------------
>
> Key: HIVE-23365
> URL: https://issues.apache.org/jira/browse/HIVE-23365
> Project: Hive
> Issue Type: Improvement
> Components: Physical Optimizer
> Reporter: Jesus Camacho Rodriguez
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23365.01.patch, HIVE-23365.02.patch, HIVE-23365.03.patch, HIVE-23365.04.patch, HIVE-23365.05.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, RS deduplication is always executed whenever it is semantically correct. However, it could be beneficial to leave both RS operators in the plan, e.g., if the NDV of the second RS is very low. Thus, we would like this decision to be cost-based. We could use a simple heuristic that would work fine for most of the cases without introducing regressions for existing cases, e.g., if NDV for partition column is less than estimated parallelism in the second RS, do not execute deduplication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)