You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/14 08:13:46 UTC

[GitHub] [incubator-streampark] jakiuncle opened a new pull request, #1840: Support Apache StreamPark SSO authentication with Casdoor

jakiuncle opened a new pull request, #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840

   ## What changes were proposed in this pull request
   Support Apache StreamPark SSO authentication with Casdoor
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
    Support SSO with casdoor in backend and fontend.
    Add casdoor-spring-boot-starter in pom.xml
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (yes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r999602107


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996415117


##########
streampark-console/streampark-console-webapp/src/views/user/SignIn.vue:
##########
@@ -86,6 +86,21 @@
             </a-button>
           </a-form-item>
         </a-form>
+        <a-form-item
+          style="margin-top:40px">
+          <a-button
+            style="padding: 0 90px"
+            size="large"
+            type="primary"
+            html-type="button"
+            class="signin-button"
+            href="http://localhost:7001/login/oauth/authorize?client_id=b6f7a3bdee5d3f424ee2&response_type=code&redirect_uri=http://localhost:10003&scope=read&state=app-test"

Review Comment:
   You can configue it in main.js now



##########
streampark-console/streampark-console-webapp/src/views/user/SignIn.vue:
##########
@@ -86,6 +86,21 @@
             </a-button>
           </a-form-item>
         </a-form>
+        <a-form-item
+          style="margin-top:40px">
+          <a-button
+            style="padding: 0 90px"
+            size="large"
+            type="primary"
+            html-type="button"
+            class="signin-button"
+            href="http://localhost:7001/login/oauth/authorize?client_id=b6f7a3bdee5d3f424ee2&response_type=code&redirect_uri=http://localhost:10003&scope=read&state=app-test"

Review Comment:
   You can configure it in main.js now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1284819536

   @lvshaokang plz review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1367332424

   @saLeox no,i close this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r1000075649


##########
streampark-console/streampark-console-service/src/main/resources/application.properties:
##########
@@ -0,0 +1,53 @@
+#

Review Comment:
   it have many configuration to enable it. it is very flexible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1283969569

   Please take a look in your free time, I'm not sure whether it will have an impact on team management, permission management etc. cc @wolfboys @1996fanrui 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1279658141

   > @wolfboys #1842 hi, this is Propsole
   
   Thanks for your feedback, I'll review it later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996447644


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   It is not recommended to throw Exception directly, but rather to handle them on a case-by-case basis.



##########
streampark-console/streampark-console-service/pom.xml:
##########
@@ -383,6 +383,12 @@
             <version>${swagger.version}</version>
         </dependency>
 
+        <dependency>
+            <groupId>org.casbin</groupId>
+            <artifactId>casdoor-spring-boot-starter</artifactId>
+            <version>1.5.1</version>

Review Comment:
   Please extract version to <properties/> frame



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] saLeox commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
saLeox commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1367688575

   > @saLeox no,i close this?
   
   No worry, I just want to know the when it can be merged, as it's a quite useful feature, and looking forward to see it soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1333024287

   hi @jakiuncle :
   
   Thanks for your contribution. I don't about the details of casdoor at present,  we will discuss it in a next version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996445007


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";
+        String username = "";
+        String password = "";
+        token = casdoorAuthService.getOAuthToken(code, state);
+        CasdoorUser casdoorUser = casdoorAuthService.parseJwtToken(token);
+        User user = userService.findByName(casdoorUser.getName());
+        if (user == null) {
+            User user2 = new User();
+            user2.setUsername(casdoorUser.getName());
+            user2.setNickName(casdoorUser.getDisplayName());
+            user2.setPassword(casdoorUser.getPassword());
+            user2.setUserType(UserType.ADMIN);

Review Comment:
   hi jakiuncle:
   thanks for your contribution, looks very good, But some details need to be discussed, welcome to subscribe to our email: [dev@streampark.apache.org](mailto:dev@streampark.apache.org), discuss together. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r997118071


##########
streampark-console/streampark-console-service/pom.xml:
##########
@@ -383,6 +383,12 @@
             <version>${swagger.version}</version>
         </dependency>
 
+        <dependency>
+            <groupId>org.casbin</groupId>
+            <artifactId>casdoor-spring-boot-starter</artifactId>
+            <version>1.5.1</version>

Review Comment:
   ok
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r998032822


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   Those are probably old codes left over, would you mind to change them together?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1279130370

   @wolfboys  https://github.com/apache/incubator-streampark/issues/1842
   hi, this is Propsole


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996257954


##########
streampark-console/streampark-console-webapp/src/views/user/SignIn.vue:
##########
@@ -86,6 +86,21 @@
             </a-button>
           </a-form-item>
         </a-form>
+        <a-form-item
+          style="margin-top:40px">
+          <a-button
+            style="padding: 0 90px"
+            size="large"
+            type="primary"
+            html-type="button"
+            class="signin-button"
+            href="http://localhost:7001/login/oauth/authorize?client_id=b6f7a3bdee5d3f424ee2&response_type=code&redirect_uri=http://localhost:10003&scope=read&state=app-test"

Review Comment:
   Maybe it would be better if this parameter can be configured



##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -63,6 +68,9 @@ public class PassportController {
     @Autowired
     private Authenticator authenticator;
 
+    @Resource

Review Comment:
   It is recommended to use `@Autowired`, because this project uses `@Autowired` uniformly



##########
streampark-console/streampark-console-service/src/main/resources/application.properties:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+casdoor.endpoint=http://localhost:8000
+casdoor.client-id=b6f7a3bdee5d3f424ee2
+casdoor.client-secret=57a04bb5e160450e634799a3f526b9bc3ca7ffd7
+casdoor.certificate=\
+-----BEGIN CERTIFICATE-----\n\
+MIIE+TCCAuGgAwIBAgIDAeJAMA0GCSqGSIb3DQEBCwUAMDYxHTAbBgNVBAoTFENh\n\
+c2Rvb3IgT3JnYW5pemF0aW9uMRUwEwYDVQQDEwxDYXNkb29yIENlcnQwHhcNMjEx\n\
+MDE1MDgxMTUyWhcNNDExMDE1MDgxMTUyWjA2MR0wGwYDVQQKExRDYXNkb29yIE9y\n\
+Z2FuaXphdGlvbjEVMBMGA1UEAxMMQ2FzZG9vciBDZXJ0MIICIjANBgkqhkiG9w0B\n\
+AQEFAAOCAg8AMIICCgKCAgEAsInpb5E1/ym0f1RfSDSSE8IR7y+lw+RJjI74e5ej\n\
+rq4b8zMYk7HeHCyZr/hmNEwEVXnhXu1P0mBeQ5ypp/QGo8vgEmjAETNmzkI1NjOQ\n\
+CjCYwUrasO/f/MnI1C0j13vx6mV1kHZjSrKsMhYY1vaxTEP3+VB8Hjg3MHFWrb07\n\
+uvFMCJe5W8+0rKErZCKTR8+9VB3janeBz//zQePFVh79bFZate/hLirPK0Go9P1g\n\
+OvwIoC1A3sarHTP4Qm/LQRt0rHqZFybdySpyWAQvhNaDFE7mTstRSBb/wUjNCUBD\n\
+PTSLVjC04WllSf6Nkfx0Z7KvmbPstSj+btvcqsvRAGtvdsB9h62Kptjs1Yn7GAuo\n\
+I3qt/4zoKbiURYxkQJXIvwCQsEftUuk5ew5zuPSlDRLoLByQTLbx0JqLAFNfW3g/\n\
+pzSDjgd/60d6HTmvbZni4SmjdyFhXCDb1Kn7N+xTojnfaNkwep2REV+RMc0fx4Gu\n\
+hRsnLsmkmUDeyIZ9aBL9oj11YEQfM2JZEq+RVtUx+wB4y8K/tD1bcY+IfnG5rBpw\n\
+IDpS262boq4SRSvb3Z7bB0w4ZxvOfJ/1VLoRftjPbLIf0bhfr/AeZMHpIKOXvfz4\n\
+yE+hqzi68wdF0VR9xYc/RbSAf7323OsjYnjjEgInUtRohnRgCpjIk/Mt2Kt84Kb0\n\
+wn8CAwEAAaMQMA4wDAYDVR0TAQH/BAIwADANBgkqhkiG9w0BAQsFAAOCAgEAn2lf\n\
+DKkLX+F1vKRO/5gJ+Plr8P5NKuQkmwH97b8CS2gS1phDyNgIc4/LSdzuf4Awe6ve\n\
+C06lVdWSIis8UPUPdjmT2uMPSNjwLxG3QsrimMURNwFlLTfRem/heJe0Zgur9J1M\n\
+8haawdSdJjH2RgmFoDeE2r8NVRfhbR8KnCO1ddTJKuS1N0/irHz21W4jt4rxzCvl\n\
+2nR42Fybap3O/g2JXMhNNROwZmNjgpsF7XVENCSuFO1jTywLaqjuXCg54IL7XVLG\n\
+omKNNNcc8h1FCeKj/nnbGMhodnFWKDTsJcbNmcOPNHo6ixzqMy/Hqc+mWYv7maAG\n\
+Jtevs3qgMZ8F9Qzr3HpUc6R3ZYYWDY/xxPisuKftOPZgtH979XC4mdf0WPnOBLqL\n\
+2DJ1zaBmjiGJolvb7XNVKcUfDXYw85ZTZQ5b9clI4e+6bmyWqQItlwt+Ati/uFEV\n\
+XzCj70B4lALX6xau1kLEpV9O1GERizYRz5P9NJNA7KoO5AVMp9w0DQTkt+LbXnZE\n\
+HHnWKy8xHQKZF9sR7YBPGLs/Ac6tviv5Ua15OgJ/8dLRZ/veyFfGo2yZsI+hKVU5\n\
+nCCJHBcAyFnm1hdvdwEdH33jDBjNB6ciotJZrf/3VYaIWSalADosHAgMWfXuWP+h\n\
+8XKXmzlxuHbTMQYtZPDgspS5aK+S4Q9wb8RRAYo=\n\
+-----END CERTIFICATE-----

Review Comment:
   I don't know what this configuration does. Can you clarify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1278974960

   hi jakiuncle:
   
   Thanks for your contribution, looks a great feature, Can you submit a [Propsole](https://github.com/apache/incubator-streampark/issues/new?assignees=&labels=Feature&template=feature-request.yml&title=%5BPropsola%5D+Propsola+title) about this feature first? Clarify the background, function And more details...
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r998032822


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   @jakiuncle Those are probably old codes left over, would you mind to change them together?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle closed pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle closed pull request #1840: Support Apache StreamPark SSO authentication with Casdoor
URL: https://github.com/apache/incubator-streampark/pull/1840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1279937752

   checkstyle failed, please fix it:
   `Error:  PassportController.java:[45,8] (imports) UnusedImports: Unused import: javax.annotation.Resource.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996415028


##########
streampark-console/streampark-console-service/src/main/resources/application.properties:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+casdoor.endpoint=http://localhost:8000
+casdoor.client-id=b6f7a3bdee5d3f424ee2
+casdoor.client-secret=57a04bb5e160450e634799a3f526b9bc3ca7ffd7
+casdoor.certificate=\
+-----BEGIN CERTIFICATE-----\n\
+MIIE+TCCAuGgAwIBAgIDAeJAMA0GCSqGSIb3DQEBCwUAMDYxHTAbBgNVBAoTFENh\n\
+c2Rvb3IgT3JnYW5pemF0aW9uMRUwEwYDVQQDEwxDYXNkb29yIENlcnQwHhcNMjEx\n\
+MDE1MDgxMTUyWhcNNDExMDE1MDgxMTUyWjA2MR0wGwYDVQQKExRDYXNkb29yIE9y\n\
+Z2FuaXphdGlvbjEVMBMGA1UEAxMMQ2FzZG9vciBDZXJ0MIICIjANBgkqhkiG9w0B\n\
+AQEFAAOCAg8AMIICCgKCAgEAsInpb5E1/ym0f1RfSDSSE8IR7y+lw+RJjI74e5ej\n\
+rq4b8zMYk7HeHCyZr/hmNEwEVXnhXu1P0mBeQ5ypp/QGo8vgEmjAETNmzkI1NjOQ\n\
+CjCYwUrasO/f/MnI1C0j13vx6mV1kHZjSrKsMhYY1vaxTEP3+VB8Hjg3MHFWrb07\n\
+uvFMCJe5W8+0rKErZCKTR8+9VB3janeBz//zQePFVh79bFZate/hLirPK0Go9P1g\n\
+OvwIoC1A3sarHTP4Qm/LQRt0rHqZFybdySpyWAQvhNaDFE7mTstRSBb/wUjNCUBD\n\
+PTSLVjC04WllSf6Nkfx0Z7KvmbPstSj+btvcqsvRAGtvdsB9h62Kptjs1Yn7GAuo\n\
+I3qt/4zoKbiURYxkQJXIvwCQsEftUuk5ew5zuPSlDRLoLByQTLbx0JqLAFNfW3g/\n\
+pzSDjgd/60d6HTmvbZni4SmjdyFhXCDb1Kn7N+xTojnfaNkwep2REV+RMc0fx4Gu\n\
+hRsnLsmkmUDeyIZ9aBL9oj11YEQfM2JZEq+RVtUx+wB4y8K/tD1bcY+IfnG5rBpw\n\
+IDpS262boq4SRSvb3Z7bB0w4ZxvOfJ/1VLoRftjPbLIf0bhfr/AeZMHpIKOXvfz4\n\
+yE+hqzi68wdF0VR9xYc/RbSAf7323OsjYnjjEgInUtRohnRgCpjIk/Mt2Kt84Kb0\n\
+wn8CAwEAAaMQMA4wDAYDVR0TAQH/BAIwADANBgkqhkiG9w0BAQsFAAOCAgEAn2lf\n\
+DKkLX+F1vKRO/5gJ+Plr8P5NKuQkmwH97b8CS2gS1phDyNgIc4/LSdzuf4Awe6ve\n\
+C06lVdWSIis8UPUPdjmT2uMPSNjwLxG3QsrimMURNwFlLTfRem/heJe0Zgur9J1M\n\
+8haawdSdJjH2RgmFoDeE2r8NVRfhbR8KnCO1ddTJKuS1N0/irHz21W4jt4rxzCvl\n\
+2nR42Fybap3O/g2JXMhNNROwZmNjgpsF7XVENCSuFO1jTywLaqjuXCg54IL7XVLG\n\
+omKNNNcc8h1FCeKj/nnbGMhodnFWKDTsJcbNmcOPNHo6ixzqMy/Hqc+mWYv7maAG\n\
+Jtevs3qgMZ8F9Qzr3HpUc6R3ZYYWDY/xxPisuKftOPZgtH979XC4mdf0WPnOBLqL\n\
+2DJ1zaBmjiGJolvb7XNVKcUfDXYw85ZTZQ5b9clI4e+6bmyWqQItlwt+Ati/uFEV\n\
+XzCj70B4lALX6xau1kLEpV9O1GERizYRz5P9NJNA7KoO5AVMp9w0DQTkt+LbXnZE\n\
+HHnWKy8xHQKZF9sR7YBPGLs/Ac6tviv5Ua15OgJ/8dLRZ/veyFfGo2yZsI+hKVU5\n\
+nCCJHBcAyFnm1hdvdwEdH33jDBjNB6ciotJZrf/3VYaIWSalADosHAgMWfXuWP+h\n\
+8XKXmzlxuHbTMQYtZPDgspS5aK+S4Q9wb8RRAYo=\n\
+-----END CERTIFICATE-----

Review Comment:
   This is cert which can make our project more safe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r997115554


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   i see this.userService.updateLoginTime(username) and authenticator.authenticate(username, password)  in sigin method also throws Exception so that i think  this.userService.updateLoginTime(username) and          userService.createUser(user2) throws Exception is ok



##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   Am I right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r998901258


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   I change my code , if it is right , i will change signin method toghter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r999601036


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +110,54 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) {
+        String token = "";
+        String username = "";
+        String password = "";
+        token = casdoorAuthService.getOAuthToken(code, state);
+        CasdoorUser casdoorUser = casdoorAuthService.parseJwtToken(token);
+        User user = userService.findByName(casdoorUser.getName());
+        if (user == null) {
+            User user2 = new User();

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle closed pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by "jakiuncle (via GitHub)" <gi...@apache.org>.
jakiuncle closed pull request #1840: Support Apache StreamPark SSO authentication with Casdoor
URL: https://github.com/apache/incubator-streampark/pull/1840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] saLeox commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
saLeox commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1367162809

   @jakiuncle @wolfboys  This feature provide SSO capability to streampark, is there any followup?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1278727926

   cc @1996fanrui @wolfboys 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1281758914

   hi jakiuncle:
   the front-end build failed, please check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996415028


##########
streampark-console/streampark-console-service/src/main/resources/application.properties:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+casdoor.endpoint=http://localhost:8000
+casdoor.client-id=b6f7a3bdee5d3f424ee2
+casdoor.client-secret=57a04bb5e160450e634799a3f526b9bc3ca7ffd7
+casdoor.certificate=\
+-----BEGIN CERTIFICATE-----\n\
+MIIE+TCCAuGgAwIBAgIDAeJAMA0GCSqGSIb3DQEBCwUAMDYxHTAbBgNVBAoTFENh\n\
+c2Rvb3IgT3JnYW5pemF0aW9uMRUwEwYDVQQDEwxDYXNkb29yIENlcnQwHhcNMjEx\n\
+MDE1MDgxMTUyWhcNNDExMDE1MDgxMTUyWjA2MR0wGwYDVQQKExRDYXNkb29yIE9y\n\
+Z2FuaXphdGlvbjEVMBMGA1UEAxMMQ2FzZG9vciBDZXJ0MIICIjANBgkqhkiG9w0B\n\
+AQEFAAOCAg8AMIICCgKCAgEAsInpb5E1/ym0f1RfSDSSE8IR7y+lw+RJjI74e5ej\n\
+rq4b8zMYk7HeHCyZr/hmNEwEVXnhXu1P0mBeQ5ypp/QGo8vgEmjAETNmzkI1NjOQ\n\
+CjCYwUrasO/f/MnI1C0j13vx6mV1kHZjSrKsMhYY1vaxTEP3+VB8Hjg3MHFWrb07\n\
+uvFMCJe5W8+0rKErZCKTR8+9VB3janeBz//zQePFVh79bFZate/hLirPK0Go9P1g\n\
+OvwIoC1A3sarHTP4Qm/LQRt0rHqZFybdySpyWAQvhNaDFE7mTstRSBb/wUjNCUBD\n\
+PTSLVjC04WllSf6Nkfx0Z7KvmbPstSj+btvcqsvRAGtvdsB9h62Kptjs1Yn7GAuo\n\
+I3qt/4zoKbiURYxkQJXIvwCQsEftUuk5ew5zuPSlDRLoLByQTLbx0JqLAFNfW3g/\n\
+pzSDjgd/60d6HTmvbZni4SmjdyFhXCDb1Kn7N+xTojnfaNkwep2REV+RMc0fx4Gu\n\
+hRsnLsmkmUDeyIZ9aBL9oj11YEQfM2JZEq+RVtUx+wB4y8K/tD1bcY+IfnG5rBpw\n\
+IDpS262boq4SRSvb3Z7bB0w4ZxvOfJ/1VLoRftjPbLIf0bhfr/AeZMHpIKOXvfz4\n\
+yE+hqzi68wdF0VR9xYc/RbSAf7323OsjYnjjEgInUtRohnRgCpjIk/Mt2Kt84Kb0\n\
+wn8CAwEAAaMQMA4wDAYDVR0TAQH/BAIwADANBgkqhkiG9w0BAQsFAAOCAgEAn2lf\n\
+DKkLX+F1vKRO/5gJ+Plr8P5NKuQkmwH97b8CS2gS1phDyNgIc4/LSdzuf4Awe6ve\n\
+C06lVdWSIis8UPUPdjmT2uMPSNjwLxG3QsrimMURNwFlLTfRem/heJe0Zgur9J1M\n\
+8haawdSdJjH2RgmFoDeE2r8NVRfhbR8KnCO1ddTJKuS1N0/irHz21W4jt4rxzCvl\n\
+2nR42Fybap3O/g2JXMhNNROwZmNjgpsF7XVENCSuFO1jTywLaqjuXCg54IL7XVLG\n\
+omKNNNcc8h1FCeKj/nnbGMhodnFWKDTsJcbNmcOPNHo6ixzqMy/Hqc+mWYv7maAG\n\
+Jtevs3qgMZ8F9Qzr3HpUc6R3ZYYWDY/xxPisuKftOPZgtH979XC4mdf0WPnOBLqL\n\
+2DJ1zaBmjiGJolvb7XNVKcUfDXYw85ZTZQ5b9clI4e+6bmyWqQItlwt+Ati/uFEV\n\
+XzCj70B4lALX6xau1kLEpV9O1GERizYRz5P9NJNA7KoO5AVMp9w0DQTkt+LbXnZE\n\
+HHnWKy8xHQKZF9sR7YBPGLs/Ac6tviv5Ua15OgJ/8dLRZ/veyFfGo2yZsI+hKVU5\n\
+nCCJHBcAyFnm1hdvdwEdH33jDBjNB6ciotJZrf/3VYaIWSalADosHAgMWfXuWP+h\n\
+8XKXmzlxuHbTMQYtZPDgspS5aK+S4Q9wb8RRAYo=\n\
+-----END CERTIFICATE-----

Review Comment:
   This is cert which can make our project safer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996415059


##########
streampark-console/streampark-console-webapp/src/views/user/SignIn.vue:
##########
@@ -86,6 +86,21 @@
             </a-button>
           </a-form-item>
         </a-form>
+        <a-form-item
+          style="margin-top:40px">
+          <a-button
+            style="padding: 0 90px"
+            size="large"
+            type="primary"
+            html-type="button"
+            class="signin-button"
+            href="http://localhost:7001/login/oauth/authorize?client_id=b6f7a3bdee5d3f424ee2&response_type=code&redirect_uri=http://localhost:10003&scope=read&state=app-test"

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r996444568


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";
+        String username = "";
+        String password = "";
+        token = casdoorAuthService.getOAuthToken(code, state);
+        CasdoorUser casdoorUser = casdoorAuthService.parseJwtToken(token);
+        User user = userService.findByName(casdoorUser.getName());
+        if (user == null) {
+            User user2 = new User();
+            user2.setUsername(casdoorUser.getName());
+            user2.setNickName(casdoorUser.getDisplayName());
+            user2.setPassword(casdoorUser.getPassword());
+            user2.setUserType(UserType.ADMIN);

Review Comment:
   Set the user type is admin, this operation needs to be discussed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on code in PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#discussion_r999385353


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +110,54 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) {
+        String token = "";
+        String username = "";
+        String password = "";
+        token = casdoorAuthService.getOAuthToken(code, state);
+        CasdoorUser casdoorUser = casdoorAuthService.parseJwtToken(token);
+        User user = userService.findByName(casdoorUser.getName());
+        if (user == null) {
+            User user2 = new User();

Review Comment:
   It is not recommended to use the variable name "user2", because it does not provide a clearly meaning



##########
streampark-console/streampark-console-service/src/main/resources/application.properties:
##########
@@ -0,0 +1,53 @@
+#

Review Comment:
   Is there additional configuration to enable it, enforcing it is not expected, and we want the user to have the choice.



##########
streampark-console/streampark-console-service/src/main/resources/application.properties:
##########
@@ -0,0 +1,53 @@
+#

Review Comment:
   Could this file be renamed `casdoor.properties`, it seems to be a casdoor-only configuration



##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
         return new RestResponse().data(userInfo);
     }
 
+    @PostMapping("signinbycasdoor")
+    public RestResponse signinByCasdoor(@NotBlank(message = "{required}") String code,
+                                        @NotBlank(message = "{required}") String state) throws Exception {
+        String token = "";

Review Comment:
   @jakiuncle Sorry, I ignored the transaction handling, let's revert to the original, and we'll discuss using unified business code to handle exceptions later, feel free to join the discussion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] jakiuncle commented on pull request #1840: Support Apache StreamPark SSO authentication with Casdoor

Posted by GitBox <gi...@apache.org>.
jakiuncle commented on PR #1840:
URL: https://github.com/apache/incubator-streampark/pull/1840#issuecomment-1333025001

   > hi @jakiuncle :
   > 
   > Thanks for your contribution. I don't about the details of casdoor at present, we will discuss it in a next version.
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org