You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/05/31 20:21:59 UTC

[GitHub] flink pull request #4725: [FLINK-7689] [Streaming Connectors] Added metrics ...

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4725#discussion_r192222854
  
    --- Diff: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java ---
    @@ -41,6 +46,11 @@
     public class JDBCOutputFormat extends RichOutputFormat<Row> {
     	private static final long serialVersionUID = 1L;
     	static final int DEFAULT_BATCH_INTERVAL = 5000;
    +	static final String FLUSH_SCOPE = "flush";
    +	static final String FLUSH_RATE_METER_NAME = "rate";
    --- End diff --
    
    I'm not convinced of the naming scheme. I would replace `FLUSH_SCOPE` with "jdbc", and explicitly prefix the rate and duration metrics with "flush".


---