[GitHub] [nifi] stan-antyufeev-8451 commented on a change in pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…

[GitBox <gi...@apache.org>]

stan-antyufeev-8451 commented on a change in pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#discussion_r646867817



##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/services/azure/storage/TestADLSCredentialsControllerService.java
##########
@@ -327,6 +327,28 @@ public void testGetCredentialsDetailsWithSasToken() throws Exception {
         assertNull(actual.getServicePrincipalClientSecret());
     }
 
+    @Test
+    public void testGetCredentialsDetailsWithSasTokenUsingEL() throws Exception {
+        // GIVEN
+        configureAccountName();
+        configureSasTokenUsingEL();
+
+        runner.enableControllerService(credentialsService);
+
+        // WHEN
+        ADLSCredentialsDetails actual = credentialsService.getCredentialsDetails(new HashMap<>());
+
+        // THEN

Review comment:
       Hi 
   Can we merge this change to proceed further?  I need this feature to test our on one of the solution built on Nifi.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org