You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/04/19 06:12:44 UTC
Review Request: FLUME-1135: flume-docs exclude is not sufficient for rat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4796/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.
This addresses bug FLUME-1135.
https://issues.apache.org/jira/browse/FLUME-1135
Diffs
-----
pom.xml ed8092d
Diff: https://reviews.apache.org/r/4796/diff
Testing
-------
This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests
Thanks,
Mike
Re: Review Request: FLUME-1135: flume-docs exclude is not sufficient for rat
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4796/#review7149
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-04-19 04:12:44, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4796/
> -----------------------------------------------------------
>
> (Updated 2012-04-19 04:12:44)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.
>
>
> This addresses bug FLUME-1135.
> https://issues.apache.org/jira/browse/FLUME-1135
>
>
> Diffs
> -----
>
> pom.xml ed8092d
>
> Diff: https://reviews.apache.org/r/4796/diff
>
>
> Testing
> -------
>
> This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests
>
>
> Thanks,
>
> Mike
>
>
Re: Review Request: FLUME-1135: flume-docs exclude is not sufficient
for rat
Posted by Prasad Mujumdar <pr...@cloudera.com>.
Hey Mike,
Please attach the patch to Jira. I will commit it upstream.
thanks
Prasad
On Thu, Apr 19, 2012 at 10:29 AM, Prasad Mujumdar <pr...@cloudera.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4796/
>
> Ship it!
>
> lgtm
>
>
> - Prasad
>
> On April 19th, 2012, 4:12 a.m., Mike Percy wrote:
> Review request for Flume.
> By Mike Percy.
>
> *Updated 2012-04-19 04:12:44*
> Description
>
> The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.
>
> Testing
>
> This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests
>
> *Bugs: * FLUME-1135 <https://issues.apache.org/jira/browse/FLUME-1135>
> Diffs
>
> - pom.xml (ed8092d)
>
> View Diff <https://reviews.apache.org/r/4796/diff/>
>
Re: Review Request: FLUME-1135: flume-docs exclude is not sufficient for rat
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4796/#review7039
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2012-04-19 04:12:44, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4796/
> -----------------------------------------------------------
>
> (Updated 2012-04-19 04:12:44)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.
>
>
> This addresses bug FLUME-1135.
> https://issues.apache.org/jira/browse/FLUME-1135
>
>
> Diffs
> -----
>
> pom.xml ed8092d
>
> Diff: https://reviews.apache.org/r/4796/diff
>
>
> Testing
> -------
>
> This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests
>
>
> Thanks,
>
> Mike
>
>