You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mikemccand (via GitHub)" <gi...@apache.org> on 2023/12/14 10:21:22 UTC
[PR] #12932: get monsters tests compiling/running again [lucene]
mikemccand opened a new pull request, #12942:
URL: https://github.com/apache/lucene/pull/12942
This just fixes a bit of rust on the monster tests so they run again ...
With this change I was able to run all monster tests, except for `Test20NewsgroupsClassification` which now fails with:
```
org.apache.lucene.classification.Test20NewsgroupsClassification > test20Newsgroups FAILED
java.io.IOException: java.lang.IllegalArgumentException: topNGroups must be >= 1 (got 0)
at __randomizedtesting.SeedInfo.seed([9C94D9A6FA5F55ED:D92A9B02BDA49C6C]:0)
at org.apache.lucene.classification.utils.DatasetSplitter.split(DatasetSplitter.java:175)
at org.apache.lucene.classification.Test20NewsgroupsClassification.test20Newsgroups(Test20NewsgroupsClassification.java:155)
```
I'm not quite sure how to fix this one so I leave it be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] #12932: get monsters tests compiling/running again [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand merged PR #12942:
URL: https://github.com/apache/lucene/pull/12942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] #12932: get monsters tests compiling/running again [lucene]
Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent commented on code in PR #12942:
URL: https://github.com/apache/lucene/pull/12942#discussion_r1426699287
##########
lucene/core/src/test/org/apache/lucene/index/Test2BPoints.java:
##########
@@ -143,6 +143,6 @@ public void test2D() throws Exception {
}
private static Codec getCodec() {
- return Codec.forName("Lucene84");
+ return Codec.getDefault();
Review Comment:
🙈
##########
lucene/core/src/test/org/apache/lucene/index/Test2BPoints.java:
##########
@@ -143,6 +143,6 @@ public void test2D() throws Exception {
}
private static Codec getCodec() {
- return Codec.forName("Lucene84");
+ return Codec.getDefault();
Review Comment:
🙈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org