You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2010/03/17 17:50:27 UTC
[jira] Created: (MYFACES-2611)
UIComponentBase.getFacetsAndChildren() must not access the component's
facets and children directly
UIComponentBase.getFacetsAndChildren() must not access the component's facets and children directly
---------------------------------------------------------------------------------------------------
Key: MYFACES-2611
URL: https://issues.apache.org/jira/browse/MYFACES-2611
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0-beta-2, 2.0.0-beta
Reporter: Jakob Korherr
Assignee: Jakob Korherr
Currently UIComponentBase.getFacetsAndChildren() accesses the component's facets and children directly over the properties _facetMap and _childrenList. This is a problem when a component does not use those fields for its children or facets. One example is the PartialViewRoot of PrimeFaces.
See also the thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55175.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2611)
UIComponentBase.getFacetsAndChildren() must not access the component's
facets and children directly
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2611.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.9-SNAPSHOT
> UIComponentBase.getFacetsAndChildren() must not access the component's facets and children directly
> ---------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2611
> URL: https://issues.apache.org/jira/browse/MYFACES-2611
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 1.2.8, 2.0.0-beta, 2.0.0-beta-2
> Reporter: Jakob Korherr
> Assignee: Leonardo Uribe
> Fix For: 1.2.9-SNAPSHOT, 2.0.0-beta-3
>
>
> Currently UIComponentBase.getFacetsAndChildren() accesses the component's facets and children directly over the properties _facetMap and _childrenList. This is a problem when a component does not use those fields for its children or facets. One example is the PartialViewRoot of PrimeFaces.
> See also the thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55175.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2611)
UIComponentBase.getFacetsAndChildren() must not access the component's
facets and children directly
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846487#action_12846487 ]
Leonardo Uribe commented on MYFACES-2611:
-----------------------------------------
The resulting code should also be committed on 1.2.x branch, because this is not jsf 2.0 specific.
> UIComponentBase.getFacetsAndChildren() must not access the component's facets and children directly
> ---------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2611
> URL: https://issues.apache.org/jira/browse/MYFACES-2611
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta, 2.0.0-beta-2
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-3
>
>
> Currently UIComponentBase.getFacetsAndChildren() accesses the component's facets and children directly over the properties _facetMap and _childrenList. This is a problem when a component does not use those fields for its children or facets. One example is the PartialViewRoot of PrimeFaces.
> See also the thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55175.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2611)
UIComponentBase.getFacetsAndChildren() must not access the component's
facets and children directly
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe reopened MYFACES-2611:
-------------------------------------
The code committed trigger the creation of wrappers. if the check for null cannot be done, it should be done through getFacetCount or getChildCount.
> UIComponentBase.getFacetsAndChildren() must not access the component's facets and children directly
> ---------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2611
> URL: https://issues.apache.org/jira/browse/MYFACES-2611
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta, 2.0.0-beta-2
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-3
>
>
> Currently UIComponentBase.getFacetsAndChildren() accesses the component's facets and children directly over the properties _facetMap and _childrenList. This is a problem when a component does not use those fields for its children or facets. One example is the PartialViewRoot of PrimeFaces.
> See also the thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55175.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2611)
UIComponentBase.getFacetsAndChildren() must not access the component's
facets and children directly
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr resolved MYFACES-2611.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-3
> UIComponentBase.getFacetsAndChildren() must not access the component's facets and children directly
> ---------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2611
> URL: https://issues.apache.org/jira/browse/MYFACES-2611
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta, 2.0.0-beta-2
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-3
>
>
> Currently UIComponentBase.getFacetsAndChildren() accesses the component's facets and children directly over the properties _facetMap and _childrenList. This is a problem when a component does not use those fields for its children or facets. One example is the PartialViewRoot of PrimeFaces.
> See also the thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55175.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.