[jira] Resolved: (LOG4NET-81) LoggerRepositorySkeleton's OnConfigurationChanged method always raises its event with EventArgs.Empty instead of passing through its EventArgs parameter.

["Ron Grabowski (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/LOG4NET-81?page=all ]
     
Ron Grabowski resolved LOG4NET-81:
----------------------------------

    Fix Version: 1.2.11
     Resolution: Fixed

OnConfigurationChanged now passes through its EventArgs parameter instead of always using EventArgs.Empty.

> LoggerRepositorySkeleton's OnConfigurationChanged method always raises its event with EventArgs.Empty instead of passing through its EventArgs parameter.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: LOG4NET-81
>          URL: http://issues.apache.org/jira/browse/LOG4NET-81
>      Project: Log4net
>         Type: Bug

>     Versions: 1.2.10
>     Reporter: Ron Grabowski
>     Assignee: Ron Grabowski
>     Priority: Trivial
>      Fix For: 1.2.11

>
> This code:
> protected virtual void OnConfigurationChanged(EventArgs e)
> {
>  if (e == null)
>  {
>   e = EventArgs.Empty;
>  }
>  LoggerRepositoryConfigurationChangedEventHandler handler = m_configurationChangedEvent;
>  if (handler != null)
>  {
>   handler(this, EventArgs.Empty);
>  }
> }
> should be changed to match the other event handlers in the class:
> protected virtual void OnConfigurationChanged(EventArgs e)
> {
>  if (e == null)
>  {
>   e = EventArgs.Empty;
>  }
>  LoggerRepositoryConfigurationChangedEventHandler handler = m_configurationChangedEvent;
>  if (handler != null)
>  {
>   handler(this, e); // do not always pass in EventArgs.Empty
>  }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira