You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/08/22 06:13:04 UTC
[05/11] hbase git commit: HBASE-Fix client.TestClientClusterStatus
(Chia-Ping Tsai)
HBASE-Fix client.TestClientClusterStatus (Chia-Ping Tsai)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/7b3291fa
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/7b3291fa
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/7b3291fa
Branch: refs/heads/HBASE-18467
Commit: 7b3291fa8b836be9539817876799994fac5de335
Parents: 70da554
Author: Michael Stack <st...@apache.org>
Authored: Mon Aug 21 14:21:30 2017 -0700
Committer: Michael Stack <st...@apache.org>
Committed: Mon Aug 21 14:21:30 2017 -0700
----------------------------------------------------------------------
.../hadoop/hbase/client/TestClientClusterStatus.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/7b3291fa/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
index 49b4ff2..484ee06 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
@@ -65,7 +65,7 @@ public class TestClientClusterStatus {
RegionServerThread rst = rsts.get(rsts.size() - 1);
DEAD = rst.getRegionServer();
DEAD.stop("Test dead servers status");
- while (!DEAD.isStopped()) {
+ while (rst.isAlive()) {
Thread.sleep(500);
}
}
@@ -155,9 +155,11 @@ public class TestClientClusterStatus {
Assert.assertNotNull(status);
Assert.assertNotNull(status.getServers());
// exclude a dead region server
- Assert.assertEquals(SLAVES, numRs);
- // live servers = primary master + nums of regionservers
- Assert.assertEquals(status.getServers().size() + 1 /*Master*/, numRs);
+ Assert.assertEquals(SLAVES -1, numRs);
+ // live servers = nums of regionservers
+ // By default, HMaster don't carry any regions so it won't report its load.
+ // Hence, it won't be in the server list.
+ Assert.assertEquals(status.getServers().size(), numRs);
Assert.assertTrue(status.getRegionsCount() > 0);
Assert.assertNotNull(status.getDeadServerNames());
Assert.assertEquals(1, status.getDeadServersSize());