You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/02 15:51:10 UTC
[GitHub] [netbeans] entlicher opened a new pull request #3150: Proper handling of LSP logging breakpoints.
entlicher opened a new pull request #3150:
URL: https://github.com/apache/netbeans/pull/3150
The logging text is implemented for Truffle breakpoints, some corrections are applied to Java breakpoints and expression evaluation in the logging text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #3150: Proper handling of LSP logging breakpoints.
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #3150:
URL: https://github.com/apache/netbeans/pull/3150#issuecomment-912394216
When examining the properties that can be associated with breakpoints via DAP, I've found some issues:
- logging breakpoints should not break the execution according to the spec.
- log message can contain {<expression>} to log expression values
- Truffle breakpoints (for guest languages) did not have an ability to log messages
The above issues are resolved by this PR:
- The LSP's `NbBreakpoint` instructs breakpoints not to suspend when there's a log message. It also translates patterns of `{...}` to `{=...}` which assure that JPDA (and now also Truffle) breakpoints evaluate the expressions.
- `TruffleLineBreakpoint` has new suspend and printText properties.
- There is a new `TruffleBreakpointsRegistry`, which associates `TruffleLineBreakpoint` (`JSLineBreakpoint` in general, which can be set in JS files) with `com.oracle.truffle.api.debug.Breakpoint` in the debuggee (represented by `ObjectReference`).
- When Truffle breakpoint is hit, we create the new `HitBreakpointInfo` and use the new `TruffleBreakpointOutput` to print out log message or condition exception for Truffle breakpoints.
- There's also a small change in JPDA's `DebuggerOutput` that assures that names of guest languages sources are printed out instead of the infrastructure's `JPDATruffleAccessor` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #3150: Proper handling of LSP logging breakpoints.
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #3150:
URL: https://github.com/apache/netbeans/pull/3150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists