[GitHub] [pinot] klsince commented on a change in pull request #8127: Add schema and segment crc to SegmentDirectoryContext

[GitBox <gi...@apache.org>]

klsince commented on a change in pull request #8127:
URL: https://github.com/apache/pinot/pull/8127#discussion_r799690656



##########
File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoaderContext.java
##########
@@ -28,22 +29,30 @@
 public class SegmentDirectoryLoaderContext {
 
   private final TableConfig _tableConfig;
+  private final Schema _schema;
   private final String _instanceId;
   private final String _segmentName;
   private final PinotConfiguration _segmentDirectoryConfigs;
+  private final String _segmentCrc;
 
-  public SegmentDirectoryLoaderContext(TableConfig tableConfig, String instanceId, String segmentName,
-      PinotConfiguration segmentDirectoryConfigs) {
+  public SegmentDirectoryLoaderContext(TableConfig tableConfig, Schema schema, String instanceId, String segmentName,

Review comment:
       nit: use a Builder so that it'd be easier to extend in future, which would avoid touching those test cases in future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org