You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by sh...@apache.org on 2019/11/08 00:45:50 UTC

[samza] branch revert-1205-fix_typo_in_SqlFieldSchema created (now def0bb9)

This is an automated email from the ASF dual-hosted git repository.

shanthoosh pushed a change to branch revert-1205-fix_typo_in_SqlFieldSchema
in repository https://gitbox.apache.org/repos/asf/samza.git.


      at def0bb9  Revert "Fixed typo in SqlFieldSchema::getValueSchema method name (#1205)"

This branch includes the following new commits:

     new def0bb9  Revert "Fixed typo in SqlFieldSchema::getValueSchema method name (#1205)"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[samza] 01/01: Revert "Fixed typo in SqlFieldSchema::getValueSchema method name (#1205)"

Posted by sh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

shanthoosh pushed a commit to branch revert-1205-fix_typo_in_SqlFieldSchema
in repository https://gitbox.apache.org/repos/asf/samza.git

commit def0bb940c59072ebe2c403617eaa2c6e9c02302
Author: shanthoosh <sv...@linkedin.com>
AuthorDate: Thu Nov 7 16:45:44 2019 -0800

    Revert "Fixed typo in SqlFieldSchema::getValueSchema method name (#1205)"
    
    This reverts commit 5defb06702d8a2d216eb07df2ba2a079731233af.
---
 samza-api/src/main/java/org/apache/samza/sql/schema/SqlFieldSchema.java | 2 +-
 .../main/java/org/apache/samza/sql/client/impl/CliCommandHandler.java   | 2 +-
 .../src/main/java/org/apache/samza/sql/planner/RelSchemaConverter.java  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/samza-api/src/main/java/org/apache/samza/sql/schema/SqlFieldSchema.java b/samza-api/src/main/java/org/apache/samza/sql/schema/SqlFieldSchema.java
index 7c4fd32..d3cec05 100644
--- a/samza-api/src/main/java/org/apache/samza/sql/schema/SqlFieldSchema.java
+++ b/samza-api/src/main/java/org/apache/samza/sql/schema/SqlFieldSchema.java
@@ -97,7 +97,7 @@ public class SqlFieldSchema {
   /**
    * Get the schema of the value if the field type is {@link SamzaSqlFieldType#MAP}
    */
-  public SqlFieldSchema getValueSchema() {
+  public SqlFieldSchema getValueScehma() {
     return valueType;
   }
 
diff --git a/samza-sql-shell/src/main/java/org/apache/samza/sql/client/impl/CliCommandHandler.java b/samza-sql-shell/src/main/java/org/apache/samza/sql/client/impl/CliCommandHandler.java
index c18c637..bb594e1 100644
--- a/samza-sql-shell/src/main/java/org/apache/samza/sql/client/impl/CliCommandHandler.java
+++ b/samza-sql-shell/src/main/java/org/apache/samza/sql/client/impl/CliCommandHandler.java
@@ -671,7 +671,7 @@ public class CliCommandHandler implements CommandHandler {
         return String.format("ARRAY(%s)", getFieldDisplayValue(fieldSchema.getElementSchema()));
       case MAP:
         return String.format("MAP(%s, %s)", SamzaSqlFieldType.STRING.toString(),
-            getFieldDisplayValue(fieldSchema.getValueSchema()));
+            getFieldDisplayValue(fieldSchema.getValueScehma()));
       case ROW:
         String rowDisplayValue = fieldSchema.getRowSchema()
             .getFields()
diff --git a/samza-sql/src/main/java/org/apache/samza/sql/planner/RelSchemaConverter.java b/samza-sql/src/main/java/org/apache/samza/sql/planner/RelSchemaConverter.java
index c2653d9..7df5916 100644
--- a/samza-sql/src/main/java/org/apache/samza/sql/planner/RelSchemaConverter.java
+++ b/samza-sql/src/main/java/org/apache/samza/sql/planner/RelSchemaConverter.java
@@ -98,7 +98,7 @@ public class RelSchemaConverter extends SqlTypeFactoryImpl {
         // TODO Calcite execution engine doesn't support record type yet.
         return createTypeWithNullability(createSqlType(SqlTypeName.ANY), true);
       case MAP:
-        RelDataType valueType = getRelDataType(fieldSchema.getValueSchema());
+        RelDataType valueType = getRelDataType(fieldSchema.getValueScehma());
         return new MapSqlType(createSqlType(SqlTypeName.VARCHAR), valueType, true);
       default:
         String msg = String.format("Field Type %s is not supported", fieldSchema.getFieldType());