You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by aa...@apache.org on 2002/01/23 07:10:30 UTC
cvs commit: apr/build apr_hints.m4
aaron 02/01/22 22:10:30
Modified: . STATUS configure.in
build apr_hints.m4
Log:
The rest of this issue is undecided, but this patch gets us
working on AIX again. On versions where -D_THREAD_SAFE will
break the build, passing --disable-threads to configure should
get things moving again.
Reviewed by: Elrond <el...@samba-tng.org>
Revision Changes Path
1.94 +16 -1 apr/STATUS
Index: STATUS
===================================================================
RCS file: /home/cvs/apr/STATUS,v
retrieving revision 1.93
retrieving revision 1.94
diff -u -r1.93 -r1.94
--- STATUS 14 Jan 2002 13:45:19 -0000 1.93
+++ STATUS 23 Jan 2002 06:10:30 -0000 1.94
@@ -1,5 +1,5 @@
APACHE PORTABLE RUNTIME (APR) LIBRARY STATUS: -*-text-*-
-Last modified at [$Date: 2002/01/14 13:45:19 $]
+Last modified at [$Date: 2002/01/23 06:10:30 $]
Release:
@@ -45,6 +45,21 @@
apr_proc_mutex_*() (Is proc_mutex unnecessary on Win32?)
RELEASE NON-SHOWSTOPPERS BUT WOULD BE REAL NICE TO WRAP THESE UP:
+
+ * Using reentrant libraries with non-threaded APR
+ - Anecdotal evidence exists that suggests it is bad to
+ mix reentrant and non-reentrant libraries and therefore
+ we should always use the reentrant versions.
+ - Unfortunately, on some platforms (AIX 4.2.1) defining
+ the reentrant flag (-D_THREAD_SAFE) causes builds to fail,
+ and so one would expect --disable-threads to fix this.
+ Although this has been fixed for that particular version
+ of AIX, it may be useful to only enable the reentrant
+ versions when threads are enabled.
+ How will we deal with this issue once APR becomes a standalone
+ library? It is perfectly legitimate to have apps needing
+ both versions (threaded/reentrant and non-threaded/non-reentrant)
+ on the same machine.
* Pools debugging
- Find a way to do check if a pool is used in multiple
1.399 +6 -0 apr/configure.in
Index: configure.in
===================================================================
RCS file: /home/cvs/apr/configure.in,v
retrieving revision 1.398
retrieving revision 1.399
diff -u -r1.398 -r1.399
--- configure.in 13 Jan 2002 04:20:10 -0000 1.398
+++ configure.in 23 Jan 2002 06:10:30 -0000 1.399
@@ -409,6 +409,12 @@
AC_DEFINE(GETHOSTBYADDR_IS_THREAD_SAFE)
fi
AC_CHECK_FUNCS(gethostbyname_r gethostbyaddr_r)
+
+ case "$host" in
+ *-ibm-aix*)
+ APR_ADDTO(CPPFLAGS, [-D_THREAD_SAFE])
+ ;;
+ esac
else
echo "APR will be non-threaded"
fi
1.33 +0 -1 apr/build/apr_hints.m4
Index: apr_hints.m4
===================================================================
RCS file: /home/cvs/apr/build/apr_hints.m4,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- apr_hints.m4 12 Dec 2001 19:35:06 -0000 1.32
+++ apr_hints.m4 23 Jan 2002 06:10:30 -0000 1.33
@@ -63,7 +63,6 @@
APR_ADDTO(CFLAGS, [-qHALT=E])
fi
APR_SETIFNULL(apr_iconv_inbuf_const, [1])
- APR_ADDTO(CPPFLAGS, [-D_THREAD_SAFE])
APR_ADDTO(LDFLAGS, [-Wl,-brtl])
;;
*-apollo-*)