You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by na...@apache.org on 2010/10/26 21:17:45 UTC

svn commit: r1027693 - in /tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src: main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java test/java/org/apache/tuscany/sca/binding/atom/ProviderFeedEntityTagsTestCase.java

Author: nash
Date: Tue Oct 26 19:17:45 2010
New Revision: 1027693

URL: http://svn.apache.org/viewvc?rev=1027693&view=rev
Log:
Merge r1025777 TUSCANY-3743: Return correct response code from If-Unmodified-Since

Modified:
    tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java
    tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/test/java/org/apache/tuscany/sca/binding/atom/ProviderFeedEntityTagsTestCase.java

Modified: tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java?rev=1027693&r1=1027692&r2=1027693&view=diff
==============================================================================
--- tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java (original)
+++ tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java Tue Oct 26 19:17:45 2010
@@ -280,7 +280,7 @@ class AtomBindingListenerServlet extends
                             Date predicateDate = dateFormat.parse( predicate ); 
                             if ( predicateDate.compareTo( exactSeconds(feedUpdated) ) < 0 ) {
                                 // Match, should short circuit
-                                response.sendError(HttpServletResponse.SC_NOT_MODIFIED);
+                                response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED);
                                 return;
                             }             		
                         } catch ( java.text.ParseException e ) {

Modified: tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/test/java/org/apache/tuscany/sca/binding/atom/ProviderFeedEntityTagsTestCase.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/test/java/org/apache/tuscany/sca/binding/atom/ProviderFeedEntityTagsTestCase.java?rev=1027693&r1=1027692&r2=1027693&view=diff
==============================================================================
--- tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/test/java/org/apache/tuscany/sca/binding/atom/ProviderFeedEntityTagsTestCase.java (original)
+++ tuscany/sca-java-1.x/trunk/modules/binding-atom-abdera/src/test/java/org/apache/tuscany/sca/binding/atom/ProviderFeedEntityTagsTestCase.java Tue Oct 26 19:17:45 2010
@@ -290,8 +290,8 @@ public class ProviderFeedEntityTagsTestC
 		ClientResponse res = client.get(providerURI, opts);
 		Assert.assertNotNull(res);
 		try {
-			// Should return 304 - Feed not provided since feed is modified since.			
-			Assert.assertEquals(304, res.getStatus());
+			// Should return 412 - Feed not provided since feed is modified since.			
+			Assert.assertEquals(412, res.getStatus());
 		} finally {
 			res.release();
 		}