You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2014/11/25 12:11:03 UTC
[GitHub] incubator-flink pull request: [FLINK-1221] Use only method name an...
GitHub user rmetzger opened a pull request:
https://github.com/apache/incubator-flink/pull/231
[FLINK-1221] Use only method name and location as default operator names
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/incubator-flink FLINK-1221-v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 877a658b7d3576d1a52177e2d7c2250274dfb149
Author: Robert Metzger <rm...@apache.org>
Date: 2014-11-21T12:15:25Z
[FLINK-1221] Use only method name and location as default operator names
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1221] Use only method name an...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/231#issuecomment-64430910
Merging this today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1221] Use only method name an...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/231#discussion_r20875678
--- Diff: flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java ---
@@ -60,7 +60,7 @@ public boolean filter(String value) throws Exception {
}
}).output(new DiscardingOuputFormat<String>());
JavaPlan plan = env.createProgramPlan();
- testForName("Filter at org.apache.flink.api.java.operators.NamesTest.testDefaultName(NamesTest.java:54)", plan);
+ testForName("Filter at testDefaultName(NamesTest.java:54)", plan);
--- End diff --
Looks better :) +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1221] Use only method name an...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---