You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/04/27 06:36:07 UTC

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #551: OAK-9754 increase default dump threshold to 16 MB and expose as system property

thomasmueller commented on code in PR #551:
URL: https://github.com/apache/jackrabbit-oak/pull/551#discussion_r859432762


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java:
##########
@@ -101,7 +102,7 @@ public class FlatFileNodeStoreBuilder {
     private long entryCount = 0;
     private File flatFileStoreDir;
     private final MemoryManager memoryManager;
-    private long dumpThreshold = DEFAULT_DUMP_THRESHOLD;
+    private long dumpThreshold = Integer.getInteger(OAK_INDEXER_DUMP_THRESHOLD_IN_MB, OAK_INDEXER_DUMP_THRESHOLD_IN_MB_DEFAULT) * FileUtils.ONE_MB;

Review Comment:
   That works, and there is no risk of integer overflow, as FileUtils.ONE_MB is a long.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org