You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/09 13:12:59 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4337: Review
code styles automatically
kezhenxu94 opened a new pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337
### Motivation:
Review code styles with some bots automatically.
### Modifications:
- Set up ReviewDog in GitHub Action to review code style.
- Add more check rules to checkstyle plugin.
### Result:
- Obvious code styles can be reviewed and commented automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584544649
@kezhenxu94 Send a notification mail to dev ml please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584449882
Merged, and conflicts showing up. Please fix, let's make this PR merged as next to avoid endless conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Set up
more strict code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316
> 2790 files changed. :P How this could be review. Haha.
I can't even review myself 😢 , that's why I configure an incremental check before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
FYI, I just configure the rules and hit `Command+Option+L`, use regular expression to remove `@author`s, they effect mostly in just JavaDoc and `import`s, so as long as the tests passed, it should be generally OK then
> Checking the failure of E2E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] github-actions[bot] commented on a change in pull
request #4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784275
##########
File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -184,6 +184,14 @@ public void onError(String typeName, ClassLoader classLoader, JavaModule module,
logger.error("Enhance class " + typeName + " error.", throwable);
}
+ /**
+ * TODO: just to test reviewdog
+ *
+ * @param typeName
+ * @param classLoader
+ * @param module
+ * @param loaded
Review comment:
**[maven-checkstyle]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub>
At-clause should have a non-empty description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] github-actions[bot] commented on a change in pull
request #4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784274
##########
File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -184,6 +184,14 @@ public void onError(String typeName, ClassLoader classLoader, JavaModule module,
logger.error("Enhance class " + typeName + " error.", throwable);
}
+ /**
+ * TODO: just to test reviewdog
+ *
+ * @param typeName
+ * @param classLoader
+ * @param module
Review comment:
**[maven-checkstyle]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub>
At-clause should have a non-empty description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] github-actions[bot] commented on a change in pull
request #4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784272
##########
File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -184,6 +184,14 @@ public void onError(String typeName, ClassLoader classLoader, JavaModule module,
logger.error("Enhance class " + typeName + " error.", throwable);
}
+ /**
+ * TODO: just to test reviewdog
+ *
+ * @param typeName
Review comment:
**[maven-checkstyle]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub>
At-clause should have a non-empty description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583977982
Related to #4272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up
more strict code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) Report
> Merging [#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/fa526e52279d553152a1c8ca8dbeb9158fad6296?src=pr&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `33.98%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4337/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4337 +/- ##
==========================================
- Coverage 26.93% 26.27% -0.66%
==========================================
Files 1177 1177
Lines 25836 26698 +862
Branches 3688 3680 -8
==========================================
+ Hits 6958 7014 +56
- Misses 18258 19067 +809
+ Partials 620 617 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/skywalking/apm/agent/core/os/ProcessorUtil.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvUHJvY2Vzc29yVXRpbC5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [...m/toolkit/log/log4j/v1/x/TraceIdPatternLayout.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuTGF5b3V0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `69.23% <ø> (ø)` | :arrow_up: |
| [.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/plugin/DynamicPluginLoader.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0R5bmFtaWNQbHVnaW5Mb2FkZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...e/skywalking/apm/agent/core/jvm/gc/G1GCModule.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL0cxR0NNb2R1bGUuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...agent/core/plugin/match/MethodAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEFubm90YXRpb25NYXRjaC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| ... and [1121 more](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=footer). Last update [fa526e5...5ddc90b](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Set up more
strict code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584543774
@apache/skywalking-committers please update the codes locally and reimport the `codeStyle.xml` into your IDEA, thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584529280
Rechecked from locally, https://repo.maven.apache.org/maven2/io/github/openfeign/feign-core/9.2.0/feign-core-9.2.0.jar download is good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785951
##########
File path: apm-checkstyle/checkStyle.xml
##########
@@ -123,4 +124,21 @@
<property name="multiLines" value="1, 2, 3, 18"/>
</module>
+ <module name="TreeWalker">
+ <property name="severity" value="warning"/>
Review comment:
Same question here. Why warning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Review
code styles automatically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583846791
I've just added checks for `@author` tag and empty JavaDoc tags (`@param`, `@return`, etc.), which are the most obvious problems that we're facing from the current contributors, if I miss some, please let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584514498
> [ERROR] Failed to execute goal on project feign-scenario: Could not resolve dependencies for project org.apache.skywalking.apm.testcase:feign-scenario:jar:1.0.0: Could not transfer artifact io.github.openfeign:feign-core:jar:9.2.0 from/to central (https://repo.maven.apache.org/maven2): Failed to transfer file https://repo.maven.apache.org/maven2/io/github/openfeign/feign-core/9.2.0/feign-core-9.2.0.jar with status code 500 -> [Help 1]
Seems like the Maven central is not stable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Set up more
strict code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316
> 2790 files changed. :P How this could be review. Haha.
I can't even review myself 😢 , that's why I configure an incremental check before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
FYI, I just configure the rules and hit `Command+Option+L`, use regular expression to remove `@author`s, they effect mostly in just JavaDoc and `import`s, so as long as the tests passed, it should be generally OK then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785766
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+
+ - name: Run reviewdog
+ env:
+ REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ ./mvnw clean -Dcheckstyle.fails.on.error=false checkstyle:checkstyle-aggregate
Review comment:
Does this get any chance to run? If checkstyle fail, the `Install & Test` step should stop the CI, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785679
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
Review comment:
Are these copy/paste issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784249
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- ./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
- CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+ ./mvnw --batch-mode -DskipTests -Drat.skip install # -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
+ # CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
Review comment:
Obviously just for quick testing, will revert when test finished
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Review
code styles automatically
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) Report
> Merging [#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e01829aa570fe7a14f69a8cf82deb99382df22a4?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4337/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4337 +/- ##
=======================================
Coverage 27.01% 27.01%
=======================================
Files 1176 1176
Lines 25677 25677
Branches 3664 3664
=======================================
Hits 6936 6936
Misses 18128 18128
Partials 613 613
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../server/telemetry/api/TelemetryRelatedContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL1RlbGVtZXRyeVJlbGF0ZWRDb250ZXh0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=footer). Last update [e01829a...fcde902](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584449406
Don't worry about profile e2e, it has a code issue which has been fixed in #4335. Waiting CI confirmation to merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Review code
styles automatically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583845951
Tests result look good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376783793
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- ./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
- CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+ ./mvnw --batch-mode -DskipTests -Drat.skip install # -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
+ # CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+
+ - name: Run reviewdog
+ env:
+ REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Review comment:
Do we have this token?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784282
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- ./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
- CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+ ./mvnw --batch-mode -DskipTests -Drat.skip install # -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
+ # CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+
+ - name: Run reviewdog
+ env:
+ REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Review comment:
It's built in GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376783775
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
Review comment:
Have you requested open `reviewdog` on GitHub?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up
more strict code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) Report
> Merging [#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/8c96fd49ddecb90bb8c98674b378c0d24483c5a7?src=pr&el=desc) will **decrease** coverage by `0.6%`.
> The diff coverage is `34.54%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4337/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4337 +/- ##
==========================================
- Coverage 27.05% 26.45% -0.61%
==========================================
Files 1176 1176
Lines 25718 26586 +868
Branches 3675 3667 -8
==========================================
+ Hits 6959 7033 +74
- Misses 18139 18941 +802
+ Partials 620 612 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/skywalking/apm/agent/core/os/ProcessorUtil.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvUHJvY2Vzc29yVXRpbC5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [...m/toolkit/log/log4j/v1/x/TraceIdPatternLayout.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuTGF5b3V0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `69.23% <ø> (ø)` | :arrow_up: |
| [.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/plugin/DynamicPluginLoader.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0R5bmFtaWNQbHVnaW5Mb2FkZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...e/skywalking/apm/agent/core/jvm/gc/G1GCModule.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL0cxR0NNb2R1bGUuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...agent/core/plugin/match/MethodAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEFubm90YXRpb25NYXRjaC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| ... and [1120 more](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=footer). Last update [8c96fd4...bd67f14](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584442794
2790 files changed. :P How this could be review. Haha.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Review code styles
automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
> I've just added checks for @author tag and empty JavaDoc tags (@param, @return, etc.), which are the most obvious problems that we're facing from the current contributors, if I miss some, please let me know
I think you should set them as an error, as removing the illegal ones once for all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584531145
@kezhenxu94 Do you agree we should merge this than waiting the CI fails again and again because of network issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] github-actions[bot] commented on a change in pull
request #4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784273
##########
File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -184,6 +184,14 @@ public void onError(String typeName, ClassLoader classLoader, JavaModule module,
logger.error("Enhance class " + typeName + " error.", throwable);
}
+ /**
+ * TODO: just to test reviewdog
+ *
+ * @param typeName
+ * @param classLoader
Review comment:
**[maven-checkstyle]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub>
At-clause should have a non-empty description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584001942
Please fix the conflicts. Besides the unstable profile e2e(will be fixed soon), there are other tests failing, please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785766
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+
+ - name: Run reviewdog
+ env:
+ REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ ./mvnw clean -Dcheckstyle.fails.on.error=false checkstyle:checkstyle-aggregate
Review comment:
Does this gets any chance to run? If checkstyle fail, the `Install & Test` step should stop the CI, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4337: Review code styles automatically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376784266
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
Review comment:
no need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376783726
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- ./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
- CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+ ./mvnw --batch-mode -DskipTests -Drat.skip install # -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
+ # CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
Review comment:
Why include `#`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584125096
Seems still failing. :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Set up
more strict code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316
> 2790 files changed. :P How this could be review. Haha.
I can't even review myself 😢 , that's why I configure an incremental check before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
FYI, I just configure the rules and hit `Command+Option+L`, use regular expression to remove `@author`s, they effect mostly in just JavaDoc and `import`s, so as long as the tests passed, it should be generally OK then
I'm Checking the failure of E2E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584510004
Fail in spring case every time, strange though. :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785766
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean cobertura:cobertura verify install javadoc:javadoc
CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s https://codecov.io/bash)
+
+ - name: Run reviewdog
+ env:
+ REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ ./mvnw clean -Dcheckstyle.fails.on.error=false checkstyle:checkstyle-aggregate
Review comment:
If this gets any chance to run? If checkstyle fail, the `Install & Test` step should stop the CI, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Review code
styles automatically
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583846791
I've just added checks for `@author` tag and empty JavaDoc tags (`@param`, `@return`, etc.), which is the most obvious problems that we're facing from the current contributors, if I miss some, please let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4337: Review code
styles automatically
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) Report
> Merging [#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e01829aa570fe7a14f69a8cf82deb99382df22a4?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4337/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4337 +/- ##
==========================================
- Coverage 27.01% 26.98% -0.03%
==========================================
Files 1176 1176
Lines 25677 25677
Branches 3664 3664
==========================================
- Hits 6936 6930 -6
- Misses 18128 18133 +5
- Partials 613 614 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../server/telemetry/api/TelemetryRelatedContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL1RlbGVtZXRyeVJlbGF0ZWRDb250ZXh0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `81.25% <0%> (-6.25%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `61.94% <0%> (-2.66%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `69.23% <0%> (-1.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=footer). Last update [e01829a...fcde902](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4337:
Review code styles automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785914
##########
File path: apm-checkstyle/checkStyle.xml
##########
@@ -20,19 +20,27 @@
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://checkstyle.org/dtds/configuration_1_3.dtd">
-<!--Refer http://checkstyle.sourceforge.net/reports/google-java-style.html#s2.2-file-encoding -->
<module name="Checker">
<property name="localeLanguage" value="en"/>
- <!--To configure the check to report on the first instance in each file-->
- <module name="FileTabCharacter"/>
+ <module name="FileTabCharacter">
+ <property name="eachLine" value="true"/>
+ </module>
<module name="RegexpSingleline">
<property name="format" value="System\.out\.println"/>
<property name="message" value="Prohibit invoking System.out.println in source code !"/>
</module>
+ <module name="RegexpSingleline">
+ <property name="severity" value="warning"/>
Review comment:
Why this is warning? I think we should remove them? (Existing @author)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Review code styles
automatically
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Review code styles automatically
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583848468
Does this review only cover the changes? I remember there are plenty of `author`, it didn't indicate them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict
code styles and fix existing issues
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584513941
Is the agent compiling test failure from one to another because of network issue? The CI passed, so I assume the compiling should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services