[GitHub] [spark] srowen commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361865083
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
 ##########
 @@ -204,9 +204,10 @@ class GBTClassifier @Since("1.4.0") (
     val boostingStrategy = super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Classification)
     val (baseLearners, learnerWeights) = if (withValidation) {
       GradientBoostedTrees.runWithValidation(trainDataset, validationDataset, boostingStrategy,
-        $(seed), $(featureSubsetStrategy))
+        $(seed), $(featureSubsetStrategy), Some(instr))
 
 Review comment:
   OK, it's slightly messy to pass the instrumentation object here, but I think none of the changes here require new computation. I'm OK with it if you think it's important to log.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org