You are viewing a plain text version of this content. The canonical link for it is here.
Posted to taglibs-dev@jakarta.apache.org by ho...@apache.org on 2004/10/19 22:47:15 UTC
cvs commit: jakarta-taglibs/standard/src/org/apache/taglibs/standard/tag/common/sql UpdateTagSupport.java
horwat 2004/10/19 13:47:15
Modified: standard/doc/web ReleaseNotes.html
standard/src/org/apache/taglibs/standard/tag/common/sql
UpdateTagSupport.java
Log:
Bugzilla #17388
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17388
Close result set created in update tag. It is good programming practive to close statements as soon as they are finished even though they will also be closed when the connection that created them is closed.
Revision Changes Path
1.60 +9 -0 jakarta-taglibs/standard/doc/web/ReleaseNotes.html
Index: ReleaseNotes.html
===================================================================
RCS file: /home/cvs/jakarta-taglibs/standard/doc/web/ReleaseNotes.html,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- ReleaseNotes.html 18 Oct 2004 22:33:21 -0000 1.59
+++ ReleaseNotes.html 19 Oct 2004 20:47:15 -0000 1.60
@@ -38,6 +38,15 @@
<tr>
<td width="27%" height="15">
<div align="center">
+ <a href="http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17388">17388</a></div>
+ </td>
+ <td width="73%" height="15">
+ <p>Close result set created in update tag. It is good programming practive to close statements as soon as they are finished even though they will also be closed when the connection that created them is closed.</p>
+ </td>
+ </tr>
+ <tr>
+ <td width="27%" height="15">
+ <div align="center">
<a href="http://nagoya.apache.org/bugzilla/show_bug.cgi?id=31313">31313</a></div>
</td>
<td width="73%" height="15">
1.29 +1 -0 jakarta-taglibs/standard/src/org/apache/taglibs/standard/tag/common/sql/UpdateTagSupport.java
Index: UpdateTagSupport.java
===================================================================
RCS file: /home/cvs/jakarta-taglibs/standard/src/org/apache/taglibs/standard/tag/common/sql/UpdateTagSupport.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- UpdateTagSupport.java 28 Feb 2004 01:01:45 -0000 1.28
+++ UpdateTagSupport.java 19 Oct 2004 20:47:15 -0000 1.29
@@ -155,6 +155,7 @@
PreparedStatement ps = conn.prepareStatement(sqlStatement);
setParameters(ps, parameters);
result = ps.executeUpdate();
+ ps.close();
}
catch (Throwable e) {
throw new JspException(sqlStatement + ": " + e.getMessage(), e);
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org