You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/08/30 15:26:33 UTC

[GitHub] [hbase] busbey commented on a change in pull request #565: [HBASE-22874] Canary should not be IA.Public

busbey commented on a change in pull request #565: [HBASE-22874] Canary should not be IA.Public
URL: https://github.com/apache/hbase/pull/565#discussion_r319562878
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
 ##########
 @@ -843,9 +876,9 @@ public int run(String[] args) throws Exception {
               }
             }
             currentTimeLength = System.currentTimeMillis() - startTime;
-            if (currentTimeLength > this.timeout) {
+            if (currentTimeLength > timeout) {
 
 Review comment:
   nit: avoid unrelated style changes like removing the `this` variables

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services