You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/09 15:52:21 UTC

[GitHub] [flink] coderappee opened a new pull request, #19924: Flink 27890

coderappee opened a new pull request, #19924:
URL: https://github.com/apache/flink/pull/19924

   ## What is the purpose of the change
   
   Fix the SideOutputExample bug introduced by [FLINK-19317].
   
   ## Brief change log
   
     - *Use the return result after assign the TimestampsAndWatermarks for the next step*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] coderappee commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
coderappee commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1152653795

   > @coderappee Let me know if you're stuck, and I can take care of this when I merge the PR.
   > 
   > In this particular situation, it should be enough to rollback the last commit in your branch and then force push to the branch in your fork that is the basis for this PR.
   
   I rollback the last commit, then use "git commit --amend" to add some changes to last second commit, and then force push to the branch for this PR.
   I do not know it is ok or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1151360957

   @coderappee You've ended up with two apparently identical commits in this PR. Could you clean that up, please? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1152070885

   @coderappee Let me know if you're stuck, and I can take care of this when I merge the PR.
   
   In this particular situation, it should be enough to rollback the last commit in your branch and then force push to the branch in your fork that is the basis for this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo closed pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
alpinegizmo closed pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks
URL: https://github.com/apache/flink/pull/19924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1151318707

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "58e7ed1e2d2333342f28fd03aed5fa53095e373a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "58e7ed1e2d2333342f28fd03aed5fa53095e373a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 58e7ed1e2d2333342f28fd03aed5fa53095e373a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] coderappee commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
coderappee commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1151713169

   > @coderappee You've ended up with two apparently identical commits in this PR. Could you clean that up, please?
   
   Could you tell me how to do it? Close this pull request and then roll back the last two commit and recommit again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1153623616

   Merged in master with a70e7045a3eabacb50f54a204bcde4fe554d8e8b
   Merged in release-1.15 with 6fcec2cf464f0467c3bb5ca3d249ac3ac754820a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
reswqa commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1151890385

   > > @coderappee You've ended up with two apparently identical commits in this PR. Could you clean that up, please?
   > 
   > Could you tell me how to do it? Close this pull request and then roll back the last two commit and recommit again?
   
   rebase the two commits to one, and force push to you own repo branch [coderappee:FLINK-27890](https://github.com/coderappee/flink/tree/FLINK-27890),it will update this pull request automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] coderappee commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

Posted by GitBox <gi...@apache.org>.
coderappee commented on PR #19924:
URL: https://github.com/apache/flink/pull/19924#issuecomment-1152655897

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org