You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by fantasticcmm <gi...@git.apache.org> on 2017/08/18 08:20:57 UTC

[GitHub] incubator-weex pull request #620: ������������������������������������������...

GitHub user fantasticcmm opened a pull request:

    https://github.com/apache/incubator-weex/pull/620

    下拉刷新组件在刷新时，快速上滑导致下拉刷新结束后不会隐藏的bug

    重现代码：https://alibaba.github.io/rax/playground/21a6bbf6-6836-41dd-ba53-03aa8e61dba7
    重现路径：下拉刷新后，快速向上滚动listview。下拉组件就卡主了。
    
    原因分析：
    下拉刷新后，向上滚动listview，会运行代码：com.taobao.weex.ui.view.refresh.core.WXSwipeLayout#onNestedPreScroll
    
    会给mCurrentAction复制为LOAD_MORE。
    当刷新结束后，调用com.taobao.weex.ui.view.refresh.core.WXSwipeLayout#finishPullRefresh时mCurrentAction == PULL_REFRESH为false，于是就不会执行com.taobao.weex.ui.view.refresh.core.WXSwipeLayout#resetHeaderView了

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fantasticcmm/incubator-weex 0.16-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #620
    
----
commit 74181e440b53fb1c593bf00f738a02809407ea8a
Author: 小明 <xi...@xiaomingdemacbook-pro.local>
Date:   2017-08-18T08:12:10Z

    下拉刷新组件在刷新时，快速上滑导致下拉刷新结束后不会隐藏的bug

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #620: [android] fix WXRefresh won`t finish as ex...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #620: �������������������������������������������������...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/620
  
    
    <!--
      1 failure:  This PR modify SD...
      2 warning:  No Changelog chan..., This PR should up...
      
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---