You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/06 00:20:00 UTC

[jira] [Commented] (IMPALA-11637) Metric admission-controller.executor-group.num-queries-executing.* should not go negative

    [ https://issues.apache.org/jira/browse/IMPALA-11637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613265#comment-17613265 ] 

ASF subversion and git services commented on IMPALA-11637:
----------------------------------------------------------

Commit 1932654252491e1e65cde06b54615a7a0fc2a8e1 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=193265425 ]

IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric

There has been occurrences where an impala backend crash and lead to
metric admission-controller.executor-group.num-queries-executing.*
goes negative. While we still investigating the exact scenario leading
into this negative metric issue, this patch add a DCHECK in
AdmissionController::UpdateExecGroupMetric to ensure that such case
does not happen in regular nightly tests.

Testing:
- Run and pass exhaustive test.

Change-Id: Icee9ae58d14d69a1548da3eccb51a00a7d727c13
Reviewed-on: http://gerrit.cloudera.org:8080/19095
Reviewed-by: Abhishek Rawat <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Metric admission-controller.executor-group.num-queries-executing.* should not go negative
> -----------------------------------------------------------------------------------------
>
>                 Key: IMPALA-11637
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11637
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Distributed Exec
>    Affects Versions: Impala 4.1.0
>            Reporter: Riza Suminto
>            Priority: Major
>
> Metric admission-controller.executor-group.num-queries-executing.* should not go negative at any time. However, we have seen some occurrence where this metric value goes negative under certain executor crash scenario.
> We need to investigate how to reproduce the crash scenario and mitigate the negative metric issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org