You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/05/24 15:49:26 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #203: Process brooklin.initializers in blueprint-composer model and introdu…
algairim opened a new pull request #203:
URL: https://github.com/apache/brooklyn-ui/pull/203
…ce requirements
Signed-off-by: Mykola Mandra <my...@cloudsoftcorp.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #203: Process brooklin.initializers in blueprint-composer model and introdu…
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #203:
URL: https://github.com/apache/brooklyn-ui/pull/203#discussion_r638068511
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html
##########
@@ -579,6 +579,12 @@ <h4>No matching configuration</h4>
</div>
</br-collapsible>
+<!-- ENTITY REQUIREMENTS -->
+<ng-include src="'blueprint-composer/component/spec-editor/section-requirements.html'"></ng-include>
+<script type="text/ng-template" id="blueprint-composer/component/spec-editor/section-requirements.html" defer-to-preexisting-id="true">
+ <!-- Placeholder for 'requirements' section. -->
+</script>
Review comment:
This is the only functional change in the template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #203: Process brooklin.initializers in blueprint-composer model and introdu…
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #203:
URL: https://github.com/apache/brooklyn-ui/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #203: Process brooklin.initializers in blueprint-composer model and introdu…
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #203:
URL: https://github.com/apache/brooklyn-ui/pull/203#discussion_r638706505
##########
File path: ui-modules/blueprint-composer/app/components/util/model/entity.model.js
##########
@@ -1138,6 +1156,19 @@ function setParametersFromJson(incomingModel) {
this.touch();
}
+/**
+ * Set initializers from JSON.
+ *
+ * @param {Object} model
+ * @param {Array} initializers
+ */
+function setInitializersFromJson(initializers) {
+ if (!Array.isArray(initializers)) {
Review comment:
I followed the pattern handling errors in this model. Brooklyn initialisers is expected to be an array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] duncangrant commented on a change in pull request #203: Process brooklin.initializers in blueprint-composer model and introdu…
Posted by GitBox <gi...@apache.org>.
duncangrant commented on a change in pull request #203:
URL: https://github.com/apache/brooklyn-ui/pull/203#discussion_r638609623
##########
File path: ui-modules/blueprint-composer/app/components/util/model/entity.model.js
##########
@@ -1138,6 +1156,19 @@ function setParametersFromJson(incomingModel) {
this.touch();
}
+/**
+ * Set initializers from JSON.
+ *
+ * @param {Object} model
+ * @param {Array} initializers
+ */
+function setInitializersFromJson(initializers) {
+ if (!Array.isArray(initializers)) {
Review comment:
I'm not sure throwing en Error here is right. Should we be more tolerant of an incorrect type or null value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #203: Process brooklin.initializers in blueprint-composer model and introdu…
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #203:
URL: https://github.com/apache/brooklyn-ui/pull/203#discussion_r638109996
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html
##########
@@ -688,9 +694,9 @@ <h4 ng-if="model.hasEnrichers() && filteredEnrichers.length === 0">No enrichers
<ng-include src="'blueprint-composer/component/spec-editor/section-others.html'"></ng-include>
<script type="text/ng-template" id="blueprint-composer/component/spec-editor/section-others.html" defer-to-preexisting-id="true">
+ <!-- Placeholder for other sections. -->
</script>
Review comment:
I would re-use 'others' section for requirements, however, it is not in the desired position. We agreed to have requirements displayed right under configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org