You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/05/19 13:17:04 UTC

Review Request 59397: SENTRY-1776 SentryStore should clear SENTRY_HMS_NOTIFICATION_ID while clearing store

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59397/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.


Bugs: SENTRY-1776
    https://issues.apache.org/jira/browse/SENTRY-1776


Repository: sentry


Description
-------

When sentry store clearAllTables() should clear SENTRY_HMS_NOTIFICATION_ID as well.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7756c4a 


Diff: https://reviews.apache.org/r/59397/diff/1/


Testing
-------

Made sure that the tests in TestSentryStore class pass.


Thanks,

kalyan kumar kalvagadda


Re: Review Request 59397: SENTRY-1776 SentryStore should clear SENTRY_HMS_NOTIFICATION_ID while clearing store

Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59397/#review175506
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Kolbasov


On May 19, 2017, 1:17 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59397/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 1:17 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
> 
> 
> Bugs: SENTRY-1776
>     https://issues.apache.org/jira/browse/SENTRY-1776
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> When sentry store clearAllTables() should clear SENTRY_HMS_NOTIFICATION_ID as well.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7756c4a 
> 
> 
> Diff: https://reviews.apache.org/r/59397/diff/1/
> 
> 
> Testing
> -------
> 
> Made sure that the tests in TestSentryStore class pass.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>


Re: Review Request 59397: SENTRY-1776 SentryStore should clear SENTRY_HMS_NOTIFICATION_ID while clearing store

Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59397/#review175501
-----------------------------------------------------------


Ship it!




Ship It!

- Sergio Pena


On May 19, 2017, 1:17 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59397/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 1:17 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
> 
> 
> Bugs: SENTRY-1776
>     https://issues.apache.org/jira/browse/SENTRY-1776
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> When sentry store clearAllTables() should clear SENTRY_HMS_NOTIFICATION_ID as well.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7756c4a 
> 
> 
> Diff: https://reviews.apache.org/r/59397/diff/1/
> 
> 
> Testing
> -------
> 
> Made sure that the tests in TestSentryStore class pass.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>