You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/08/26 10:28:56 UTC

Style update

Hi all,

according to Stas and the style guide,
we write

my(
instead of
my (

I'm in New Hampshire in the woods until Wednesday.

See attached:



	
-- 
END
------------------------------------------------------------
     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
   http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com

Re: Style update

Posted by Perrin Harkins <pe...@elem.com>.
Stas Bekman wrote:
> Thanks a lot Philip for doing a great job!

Agreed.  Philip++!

- Perrin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Thanks a lot Philip for doing a great job!

+1

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by Stas Bekman <st...@stason.org>.
Philip M. Gollucci wrote:
> Stas Bekman wrote:
> 
>> I don't really care either way, as long as things are consistent.
> 
> Okay, back from vacation.  I think the consensus was
> 
> my (
> instead of
> my(
> 
> I'll resubmit a patch for viewing to do that instead of the initial 
> way.  I'll also update the style guide.

But please try to submit it in chunks (several emails, especially the 
docs) so it'll be easier to review :) And also try not to have other 
unrelated changes in those patches :) Also if you feel like you are doing 
the right thing, go ahead and commit those right away. After all those are 
cosmetic changes...

Thanks a lot Philip for doing a great job!

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Stas Bekman wrote:
> I don't really care either way, as long as things are consistent.
Okay, back from vacation.  I think the consensus was

my (
instead of
my(

I'll resubmit a patch for viewing to do that instead of the initial way.  I'll also update the style guide.

I'm thinking Thu/Fri.


-- 
END
------------------------------------------------------------
     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
   http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by Perrin Harkins <pe...@elem.com>.
On Wed, 2005-09-07 at 13:57 -0400, Philip M. Gollucci wrote:
> Say Perrin, do you have the perltidy options/args/config handy.

I was just referring to the default settings, which are based on
perlstyle.

- Perrin


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Stas Bekman wrote:
> Perrin Harkins wrote:
> 
>> On Fri, 2005-08-26 at 12:28 -0400, Geoffrey Young wrote:
>>
>>> personally, I find the former painful to look at :)
>>
>>  
>> I agree, and so does perltidy.
> 
> 
> I don't really care either way, as long as things are consistent.
Say Perrin, do you have the perltidy options/args/config handy.  If so, I'll add them to the docs site.


-- 
END
------------------------------------------------------------
     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
   http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by Stas Bekman <st...@stason.org>.
Perrin Harkins wrote:
> On Fri, 2005-08-26 at 12:28 -0400, Geoffrey Young wrote:
> 
>>personally, I find the former painful to look at :)
>  
> I agree, and so does perltidy.

I don't really care either way, as long as things are consistent.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by Perrin Harkins <pe...@elem.com>.
On Fri, 2005-08-26 at 12:28 -0400, Geoffrey Young wrote:
> personally, I find the former painful to look at :)

I agree, and so does perltidy.

- Perrin


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: Style update

Posted by Geoffrey Young <ge...@modperlcookbook.org>.

Philip M. Gollucci wrote:
> Hi all,
> 
> according to Stas and the style guide,
> we write
> 
> my(
> instead of
> my (

this isn't serious, is it?  there are a few style things I'm not fond of but
can get over (I'll even buy perrin's recent use.perl argument... well,
partly :), but I'd think that we'd inforce the latter form, especially given
how most of us seem to follow the "whitespace for clarity" mantra and avoid
lumping things together.

personally, I find the former painful to look at :)

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org