You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/06/12 05:38:00 UTC
[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should
cache per-hit value
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133940#comment-17133940 ]
ASF subversion and git services commented on LUCENE-8574:
---------------------------------------------------------
Commit 2991acf8fffe9dbeda20c24479b108bfb8ea9257 in lucene-solr's branch refs/heads/master from Patrick Zhai
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2991acf ]
LUCENE-9391: Upgrade HPPC to 0.8.2 (#1560)
* LUCENE-8574: Upgrade HPPC to 0.8.2 (Co-authored-by: Haoyu Zhai <ha...@amazon.com>)
> ExpressionFunctionValues should cache per-hit value
> ---------------------------------------------------
>
> Key: LUCENE-8574
> URL: https://issues.apache.org/jira/browse/LUCENE-8574
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 7.5, 8.0
> Reporter: Michael McCandless
> Assignee: Robert Muir
> Priority: Major
> Attachments: LUCENE-8574.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The original version of {{ExpressionFunctionValues}} had a simple per-hit cache, so that nested expressions that reference the same common variable would compute the value for that variable the first time it was referenced and then use that cached value for all subsequent invocations, within one hit. I think it was accidentally removed in LUCENE-7609?
> This is quite important if you have non-trivial expressions that reference the same variable multiple times.
> E.g. if I have these expressions:
> {noformat}
> x = c + d
> c = b + 2
> d = b * 2{noformat}
> Then evaluating x should only cause b's value to be computed once (for a given hit), but today it's computed twice. The problem is combinatoric if b then references another variable multiple times, etc.
> I think to fix this we just need to restore the per-hit cache?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org