You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/08/01 00:10:18 UTC
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 10:10 p.m.)
Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
Changes
-------
Done
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 11:10 p.m.)
Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8a8b792
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java f071e64
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49300
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On July 31, 2014, 11:03 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 11:03 p.m.)
>
>
> Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49299
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On July 31, 2014, 11:03 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 11:03 p.m.)
>
>
> Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 11:03 p.m.)
Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk