You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cz...@apache.org on 2009/03/05 17:38:26 UTC

svn commit: r750504 - in /felix/trunk/webconsole/src/main: java/org/apache/felix/webconsole/internal/misc/EventAdminServlet.java resources/res/ui/bundles.js resources/res/ui/events.js

Author: cziegeler
Date: Thu Mar  5 16:38:26 2009
New Revision: 750504

URL: http://svn.apache.org/viewvc?rev=750504&view=rev
Log:
FELIX-975 : Unify used javascript used throughout bundles and correctly align buttons in event table for IE

Modified:
    felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/misc/EventAdminServlet.java
    felix/trunk/webconsole/src/main/resources/res/ui/bundles.js
    felix/trunk/webconsole/src/main/resources/res/ui/events.js

Modified: felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/misc/EventAdminServlet.java
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/misc/EventAdminServlet.java?rev=750504&r1=750503&r2=750504&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/misc/EventAdminServlet.java (original)
+++ felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/misc/EventAdminServlet.java Thu Mar  5 16:38:26 2009
@@ -236,6 +236,8 @@
         final String appRoot = ( String ) request.getAttribute( OsgiManager.ATTR_APP_ROOT );
         Util.script(pw, appRoot, "events.js");
 
+        pw.println( "<div id='plugin_content'/>");
+
         Util.startScript( pw );
         pw.println( "renderEvents( );" );
         Util.endScript( pw );

Modified: felix/trunk/webconsole/src/main/resources/res/ui/bundles.js
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/resources/res/ui/bundles.js?rev=750504&r1=750503&r2=750504&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/resources/res/ui/bundles.js (original)
+++ felix/trunk/webconsole/src/main/resources/res/ui/bundles.js Thu Mar  5 16:38:26 2009
@@ -18,10 +18,10 @@
 	$("#plugin_content").append( "<div class='fullwidth'><div class='statusline'/></div>" );
 }
 
-function renderView( /* Array of String */ columns, /* Array of String */ buttons ) {
+function renderView( /* Array of String */ columns, /* String */ buttons ) {
     renderStatusLine();
     renderButtons(buttons);
-    var txt = "<div class='table'><table id='bundles' class='tablelayout'><thead><tr>";
+    var txt = "<div class='table'><table id='plugin_table' class='tablelayout'><thead><tr>";
     for ( var name in columns ) {
     	txt = txt + "<th class='col_" + columns[name] + "'>" + columns[name] + "</th>";
     }
@@ -38,11 +38,11 @@
 
 function renderData( eventData )  {
 	$(".statusline").empty().append(eventData.status);
-	$("#bundles > tbody > tr").remove();
+	$("#plugin_table > tbody > tr").remove();
     for ( var idx in eventData.data ) {
         entry( eventData.data[idx] );
     }
-    $("#bundles").trigger("update");
+    $("#plugin_table").trigger("update");
     if ( drawDetails ) {
 	    renderDetails(eventData);
     }
@@ -51,7 +51,7 @@
 function entry( /* Object */ dataEntry ) {
     var trElement = tr( null, { id: "entry" + dataEntry.id } );
     entryInternal( trElement,  dataEntry );
-	$("#bundles > tbody").append(trElement);	
+	$("#plugin_table > tbody").append(trElement);	
 }
 
 function actionButton( /* Element */ parent, /* string */ id, /* Obj */ action ) {
@@ -225,7 +225,7 @@
             }
             return node.innerHTML;
         };
-        $("#bundles").tablesorter({
+        $("#plugin_table").tablesorter({
             headers: {
         	    0: { sorter:"digit"},
                 3: { sorter: false }

Modified: felix/trunk/webconsole/src/main/resources/res/ui/events.js
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/resources/res/ui/events.js?rev=750504&r1=750503&r2=750504&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/resources/res/ui/events.js (original)
+++ felix/trunk/webconsole/src/main/resources/res/ui/events.js Thu Mar  5 16:38:26 2009
@@ -15,53 +15,40 @@
  * limitations under the License.
  */
 function renderStatusLine() {
-    document.write( "<div class='fullwidth'>");
-    document.write( "<div class='statusline'></div>" );
-    document.write( "</div>" );
+	$("#plugin_content").append( "<div class='fullwidth'><div class='statusline'/></div>" );
 }
 
-function renderView( /* Array of String */ columns, /* Array of String */ buttons ) {
+function renderView( /* Array of String */ columns, /* String */ buttons ) {
     renderStatusLine();
     renderButtons(buttons);
-	document.write( "<div class='table'>");
-    document.write( "<table id='events' class='tablelayout'>" );
-
-    document.write( "<thead><tr>" );
+    var txt = "<div class='table'><table id='plugin_table' class='tablelayout'><thead><tr>";
     for ( var name in columns ) {
-        document.write( "<th>" + columns[name] + "</th>" );
+    	txt = txt + "<th class='col_" + columns[name] + "'>" + columns[name] + "</th>";
     }
-    document.write( "</tr></thead><tbody>" );
-    document.write( "</tbody></table>" );
-    document.write( "</div>");
+    txt = txt + "</tr></thead><tbody></tbody></table></div>";
+    $("#plugin_content").append( txt );
     renderButtons(buttons);
     renderStatusLine();	
 }
 
 function renderButtons( buttons ) {
-	document.write( "<div class='fullwidth'>");
-    document.write( "<div class='buttons'>" );
-    for( var b in buttons ) {
-    	document.write( "<div class='button'>");
-    	document.write(buttons[b]);
-    	document.write( "</div>");
-    }
-    document.write( "</div>" );
-    document.write( "</div>" );
+	$("#plugin_content").append( "<form method='post' enctype='multipart/form-data'><div class='fullwidth'><div class='buttons'>" +
+	                             buttons + "</div></div></form>" );
 }
 
 function renderData( eventData )  {
 	$(".statusline").empty().append(eventData.status);
-	$("#events > tbody > tr").remove();	
+	$("#plugin_table > tbody > tr").remove();	
     for ( var idx in eventData.data ) {
         entry( eventData.data[idx] );
     }
-    $("#events").trigger("update");
+    $("#plugin_table").trigger("update");
 }
 
 function entry( /* Object */ dataEntry ) {
     var trElement = tr( null, { id: "entry" + dataEntry.id } );
     entryInternal( trElement,  dataEntry );
-	$("#events > tbody").append(trElement);	
+	$("#plugin_table > tbody").append(trElement);	
 }
 
 
@@ -107,18 +94,19 @@
 }
 
 function renderEvents() {
-    renderView( ["Received", "Topic", "Properties"],
-    		["<button class='clearButton' type='button' name='clear'>Clear List</button>",
-    		 "<button class='reloadButton' type='button' name='reload'>Reload</button>"]);
-	
-    loadData();
-    
-    $("#events").tablesorter();
-    $(".reloadButton").click(loadData);
-    $(".clearButton").click(function () {
-    	$("#events > tbody > tr").remove();
-    	$.post(pluginRoot, { "action":"clear" }, function(data) {
-    	    renderData(data);
-    	}, "json");
-    });
+	$(document).ready(function(){
+	    renderView( ["Received", "Topic", "Properties"],
+	    		 "<button class='clearButton' type='button' name='clear'>Clear List</button>" +
+	    		 "<button class='reloadButton' type='button' name='reload'>Reload</button>");
+	    loadData();
+	    
+	    $("#plugin_table").tablesorter();
+	    $(".reloadButton").click(loadData);
+	    $(".clearButton").click(function () {
+	    	$("#plugin_table > tbody > tr").remove();
+	    	$.post(pluginRoot, { "action":"clear" }, function(data) {
+	    	    renderData(data);
+	    	}, "json");
+	    });
+	});
 }