You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/10 08:37:35 UTC

[GitHub] [ignite-3] vldpyatkov commented on a change in pull request #700: IGNITE-16543

vldpyatkov commented on a change in pull request #700:
URL: https://github.com/apache/ignite-3/pull/700#discussion_r823466454



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/causality/VersionedValue.java
##########
@@ -300,6 +323,14 @@ private void onStorageRevisionUpdate(long causalityToken) {
         assert causalityToken > actualToken0 : IgniteStringFormatter.format(
                 "New token should be greater than current [current={}, new={}]", actualToken0, causalityToken);
 
+        synchronized (updateMutex) {

Review comment:
       We assume the revision update method cannot invoke before any setting value.
   I think, we may sure the assumption will work to updating similarly and no reason to prevent concurrency here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org