You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/07/13 07:07:42 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41984: [MINOR] Removing redundant parentheses from SQL function docs
panbingkun opened a new pull request, #41984:
URL: https://github.com/apache/spark/pull/41984
### What changes were proposed in this pull request?
The pr aims to removing redundant parentheses from SQL function docs.
### Why are the changes needed?
Reduce misunderstandings.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Manually test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1633840193
<img width="1065" alt="image" src="https://github.com/apache/spark/assets/15246973/b67fd3c4-61eb-468d-b8bb-c52b6cbf576b">
In fact, I accidentally changed one of the PR related to `connect function` a few days ago.
https://github.com/apache/spark/pull/41902/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1635177811
@HyukjinKwon
Are the above two questions worth doing? To summarize:
1. Make [FunctionRegistry](https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#)'s classification more accurate
2. Align Scala and Python side classification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1633692488
cc @HyukjinKwon @MaxGekk @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1633812686
Any other similar case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1634069791
No further others similar case have been found so far,
Also, I would like to use this place to discuss some question:
- In [FunctionRegistry](https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L300), the classification of some functions is incorrect, is it worth doing? eg:
https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L357-L363
Obviously, the function `Abs` belongs to https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L384-L388
- Do we need to align the classification of functions in scala with that in Python? eg: `EqualNull`
In scala, it belongs to `Misc Function`
https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala#L1114-L1117
https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L721-L748
In python, it belongs to `Predicate Functions`
https://github.com/apache/spark/blob/8bb07388ea664303d0d22b03cca11a46498b772d/python/docs/source/reference/pyspark.sql/functions.rst?plain=1#L514-L520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
URL: https://github.com/apache/spark/pull/41984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1633818172
Currently, no other similar case have been found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1635059315
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41984: [MINOR] Removing redundant parentheses from SQL function docs
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41984:
URL: https://github.com/apache/spark/pull/41984#issuecomment-1633691014
<img width="720" alt="image" src="https://github.com/apache/spark/assets/15246973/ccb15d9f-a6e3-4656-adbf-f0c6dd913ee8">
Extra parentheses, this looks weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org