You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/27 16:34:31 UTC

[GitHub] [spark] pgillet commented on pull request #30523: Fix executor blank pages behind proxy

pgillet commented on pull request #30523:
URL: https://github.com/apache/spark/pull/30523#issuecomment-734912789


   > Seems OK. This would not change behavior if the proxy is not set, right? I'm trying to think of any case this would break, like framing the Spark UI in another app?
   > Can you make a JIRA?
   
   There are already other uses of `apiRoot` for constructing URLs, especially in `historypage.js`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org