[GitHub] [pulsar] Jason918 commented on a diff in pull request #16096: [cleanup][broker]remove unused field variable in in the constructor of LeastLongTermMessageRate

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #16096:
URL: https://github.com/apache/pulsar/pull/16096#discussion_r901224090


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/ModularLoadManagerStrategy.java:
##########
@@ -49,17 +49,15 @@ Optional<String> selectBroker(Set<String> candidates, BundleData bundleToAssign,
     /**
      * Create a placement strategy using the configuration.
      *
-     * @param conf
-     *            ServiceConfiguration to use.
      * @return A placement strategy from the given configurations.
      */
-    static ModularLoadManagerStrategy create(final ServiceConfiguration conf) {
+    static ModularLoadManagerStrategy create() {

Review Comment:
   IMO, better to keep this in case we create some new `ModularLoadManagerStrategy` and needs configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org