[GitHub] [tvm] leandron commented on issue #7751: Inconsistent python dependencies "tlcpack-sphinx-addon, synr" in CI and Docker setup scripts

[GitBox <gi...@apache.org>]

leandron commented on issue #7751:
URL: https://github.com/apache/tvm/issues/7751#issuecomment-808327665


   > yeah I also hit this problem. I think we need to fix the CI image update process so it is not such a burden. My opinion is we should implement one method to include dependencies in TVM CI and support that method, and avoid making CI-time additions like these two. I hit this problem with updating ci-arm and ci-cpu containers as well.
   
   > I think if we make the CI image update process less of a burden, it wouldn't be a big deal to ask us to update all ci-* containers at once, rather than having ci-cpu built 3 weeks ago and ci-gpu built 3 months ago.
   
   I think updating all images at once would be really good, in terms of keeping track of changes that happen in our dependencies.
   
   Specifically in this case, even if we rebuild (**not** from scratch) the image, we'll still end up with the old `synr` version, because Docker will use the cached layer, as the hash of script that install those dependencies didn't change, hence the need for the script to perform the ad-hoc dependency installation. 
   
   So, I think [your proposal](https://discuss.tvm.apache.org/t/rfc-python-dependencies-in-tvm-ci-containers/9011) comes in very handy. When any python dependency version change, that consolidated file hash will change, and trigger a proper rebuild of the layers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org